Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
rtase: Refine the if statement
Refine the if statement to improve readability.
Signed-off-by: Justin Lai <justinlai0215@realtek.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Link: https://patch.msgid.link/20241206084851.760475-1-justinlai0215@realtek.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
authored by
Justin Lai
and committed by
Jakub Kicinski
7ea27457
72e2e2f5
+6
-6
+6
-6
drivers/net/ethernet/realtek/rtase/rtase_main.c
+6
-6
drivers/net/ethernet/realtek/rtase/rtase_main.c
···
2018
2018
SET_NETDEV_DEV(dev, &pdev->dev);
2019
2019
2020
2020
ret = pci_enable_device(pdev);
2021
-
if (ret < 0)
2021
+
if (ret)
2022
2022
goto err_out_free_dev;
2023
2023
2024
2024
/* make sure PCI base addr 1 is MMIO */
···
2034
2034
}
2035
2035
2036
2036
ret = pci_request_regions(pdev, KBUILD_MODNAME);
2037
-
if (ret < 0)
2037
+
if (ret)
2038
2038
goto err_out_disable;
2039
2039
2040
2040
ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
···
2110
2110
dev_dbg(&pdev->dev, "Automotive Switch Ethernet driver loaded\n");
2111
2111
2112
2112
ret = rtase_init_board(pdev, &dev, &ioaddr);
2113
-
if (ret != 0)
2113
+
if (ret)
2114
2114
return ret;
2115
2115
2116
2116
tp = netdev_priv(dev);
···
2120
2120
2121
2121
/* identify chip attached to board */
2122
2122
ret = rtase_check_mac_version_valid(tp);
2123
-
if (ret != 0) {
2123
+
if (ret) {
2124
2124
dev_err(&pdev->dev,
2125
2125
"unknown chip version: 0x%08x, contact rtase maintainers (see MAINTAINERS file)\n",
2126
2126
tp->hw_ver);
···
2131
2131
rtase_init_hardware(tp);
2132
2132
2133
2133
ret = rtase_alloc_interrupt(pdev, tp);
2134
-
if (ret < 0) {
2134
+
if (ret) {
2135
2135
dev_err(&pdev->dev, "unable to alloc MSIX/MSI\n");
2136
2136
goto err_out_del_napi;
2137
2137
}
···
2176
2176
netif_carrier_off(dev);
2177
2177
2178
2178
ret = register_netdev(dev);
2179
-
if (ret != 0)
2179
+
if (ret)
2180
2180
goto err_out_free_dma;
2181
2181
2182
2182
netdev_dbg(dev, "%pM, IRQ %d\n", dev->dev_addr, dev->irq);