tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/amd/pm: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230522155245.2336818-1-azeemshaikh38@gmail.com

authored by

Azeem Shaikh and committed by
Kees Cook 7f09a3a0 992b8fe1

+1 -1
+1 -1
drivers/gpu/drm/amd/pm/legacy-dpm/legacy_dpm.c
··· 794 794 struct i2c_board_info info = { }; 795 795 const char *name = pp_lib_thermal_controller_names[controller->ucType]; 796 796 info.addr = controller->ucI2cAddress >> 1; 797 - strlcpy(info.type, name, sizeof(info.type)); 797 + strscpy(info.type, name, sizeof(info.type)); 798 798 i2c_new_client_device(&adev->pm.i2c_bus->adapter, &info); 799 799 } 800 800 } else {