tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/amdgpu: replace use of system_unbound_wq with system_dfl_wq

This patch continues the effort to refactor workqueue APIs, which has begun
with the changes introducing new workqueues and a new alloc_workqueue flag:

commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

The point of the refactoring is to eventually alter the default behavior of
workqueues to become unbound by default so that their workload placement is
optimized by the scheduler.

Before that to happen after a careful review and conversion of each individual
case, workqueue users must be converted to the better named new workqueues with
no intended behaviour changes:

system_wq -> system_percpu_wq
system_unbound_wq -> system_dfl_wq

This way the old obsolete workqueues (system_wq, system_unbound_wq) can be
removed in the future.

Suggested-by: Tejun Heo <tj@kernel.org>
Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

authored by

Marco Crivellari and committed by
Alex Deucher 7f0fc003 3ecee207

+3 -3
+1 -1
drivers/gpu/drm/amd/amdgpu/aldebaran.c
··· 179 179 list_for_each_entry(tmp_adev, reset_device_list, reset_list) { 180 180 /* For XGMI run all resets in parallel to speed up the process */ 181 181 if (tmp_adev->gmc.xgmi.num_physical_nodes > 1) { 182 - if (!queue_work(system_unbound_wq, 182 + if (!queue_work(system_dfl_wq, 183 183 &tmp_adev->reset_cntl->reset_work)) 184 184 r = -EALREADY; 185 185 } else
+1 -1
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
··· 5339 5339 list_for_each_entry(tmp_adev, device_list_handle, reset_list) { 5340 5340 /* For XGMI run all resets in parallel to speed up the process */ 5341 5341 if (tmp_adev->gmc.xgmi.num_physical_nodes > 1) { 5342 - if (!queue_work(system_unbound_wq, 5342 + if (!queue_work(system_dfl_wq, 5343 5343 &tmp_adev->xgmi_reset_work)) 5344 5344 r = -EALREADY; 5345 5345 } else
+1 -1
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
··· 116 116 /* Mode1 reset needs to be triggered on all devices together */ 117 117 list_for_each_entry(tmp_adev, reset_device_list, reset_list) { 118 118 /* For XGMI run all resets in parallel to speed up the process */ 119 - if (!queue_work(system_unbound_wq, &tmp_adev->xgmi_reset_work)) 119 + if (!queue_work(system_dfl_wq, &tmp_adev->xgmi_reset_work)) 120 120 r = -EALREADY; 121 121 if (r) { 122 122 dev_err(tmp_adev->dev,