Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

tmpfs: fix regression hang in fallocate undo

The well-spotted fallocate undo fix is good in most cases, but not when
fallocate failed on the very first page. index 0 then passes lend -1
to shmem_undo_range(), and that has two bad effects: (a) that it will
undo every fallocation throughout the file, unrestricted by the current
range; but more importantly (b) it can cause the undo to hang, because
lend -1 is treated as truncation, which makes it keep on retrying until
every page has gone, but those already fully instantiated will never go
away. Big thank you to xfstests generic/269 which demonstrates this.

Fixes: b9b4bb26af01 ("tmpfs: don't undo fallocate past its last page")
Cc: stable@vger.kernel.org
Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Hugh Dickins and committed by
Linus Torvalds
7f556567 617a8d6b

+5 -3
+5 -3
mm/shmem.c
··· 2225 2225 error = shmem_getpage(inode, index, &page, SGP_FALLOC); 2226 2226 if (error) { 2227 2227 /* Remove the !PageUptodate pages we added */ 2228 - shmem_undo_range(inode, 2229 - (loff_t)start << PAGE_SHIFT, 2230 - ((loff_t)index << PAGE_SHIFT) - 1, true); 2228 + if (index > start) { 2229 + shmem_undo_range(inode, 2230 + (loff_t)start << PAGE_SHIFT, 2231 + ((loff_t)index << PAGE_SHIFT) - 1, true); 2232 + } 2231 2233 goto undone; 2232 2234 } 2233 2235