tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: qcom-qmp-ufs: Remove qmp_ufs_exit() and Inline qmp_ufs_com_exit()

qmp_ufs_exit() is a wrapper function. It only calls qmp_ufs_com_exit().
Remove it to simplify the ufs phy driver.

Additonally partial Inline(dropping the reset assert) qmp_ufs_com_exit
into qmp_ufs_power_off function to avoid unnecessary function call
and to align with the Phy programming guide.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
Link: https://lore.kernel.org/r/20250526153821.7918-9-quic_nitirawa@quicinc.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Nitin Rawat and committed by
Vinod Koul 7f600f0e acc6b0d7

+3 -14
+3 -14
drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
··· 1758 1758 qmp_ufs_init_all(qmp, &cfg->tbls_hs_b); 1759 1759 } 1760 1760 1761 - static int qmp_ufs_com_exit(struct qmp_ufs *qmp) 1762 - { 1763 - const struct qmp_phy_cfg *cfg = qmp->cfg; 1764 - 1765 - reset_control_assert(qmp->ufs_reset); 1766 - 1767 - clk_bulk_disable_unprepare(qmp->num_clks, qmp->clks); 1768 - 1769 - regulator_bulk_disable(cfg->num_vregs, qmp->vregs); 1770 - 1771 - return 0; 1772 - } 1773 - 1774 1761 static int qmp_ufs_power_on(struct phy *phy) 1775 1762 { 1776 1763 struct qmp_ufs *qmp = phy_get_drvdata(phy); ··· 1836 1849 qphy_clrbits(qmp->pcs, cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL], 1837 1850 SW_PWRDN); 1838 1851 1839 - qmp_ufs_com_exit(qmp); 1852 + clk_bulk_disable_unprepare(qmp->num_clks, qmp->clks); 1853 + 1854 + regulator_bulk_disable(cfg->num_vregs, qmp->vregs); 1840 1855 1841 1856 return 0; 1842 1857 }