tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

dw_dmac: fix copy/paste bug in tasklet

The tasklet checks RAW.BLOCK twice, and does not check RAW.XFER. This is
obviously wrong, and could theoretically cause the driver to hang.

Reported-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Acked-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Haavard Skinnemoen and committed by
Linus Torvalds 7fe7b2f4 09b05f5e

+1 -1
+1 -1
drivers/dma/dw_dmac.c
··· 364 364 int i; 365 365 366 366 status_block = dma_readl(dw, RAW.BLOCK); 367 - status_xfer = dma_readl(dw, RAW.BLOCK); 367 + status_xfer = dma_readl(dw, RAW.XFER); 368 368 status_err = dma_readl(dw, RAW.ERROR); 369 369 370 370 dev_vdbg(dw->dma.dev, "tasklet: status_block=%x status_err=%x\n",