tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: tegra: xusb: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-25-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Uwe Kleine-König and committed by
Vinod Koul 80460691 31d0d4e0

+2 -4
+2 -4
drivers/phy/tegra/xusb.c
··· 1267 1267 return err; 1268 1268 } 1269 1269 1270 - static int tegra_xusb_padctl_remove(struct platform_device *pdev) 1270 + static void tegra_xusb_padctl_remove(struct platform_device *pdev) 1271 1271 { 1272 1272 struct tegra_xusb_padctl *padctl = platform_get_drvdata(pdev); 1273 1273 int err; ··· 1285 1285 dev_err(&pdev->dev, "failed to assert reset: %d\n", err); 1286 1286 1287 1287 padctl->soc->ops->remove(padctl); 1288 - 1289 - return 0; 1290 1288 } 1291 1289 1292 1290 static __maybe_unused int tegra_xusb_padctl_suspend_noirq(struct device *dev) ··· 1319 1321 .pm = &tegra_xusb_padctl_pm_ops, 1320 1322 }, 1321 1323 .probe = tegra_xusb_padctl_probe, 1322 - .remove = tegra_xusb_padctl_remove, 1324 + .remove_new = tegra_xusb_padctl_remove, 1323 1325 }; 1324 1326 module_platform_driver(tegra_xusb_padctl_driver); 1325 1327