tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/i915/dp: Reprobe connector if getting/acking link service IRQs fails

An AUX access failure during HPD IRQ handling should be handled by
falling back to a full connector detection, ensure that if the failure
happens while reading/acking a link service IRQ.

While at it add code comment documenting the return value of
intel_dp_check_link_service_irq().

v2: Docuement intel_dp_check_link_service_irq()'s return value. (Jani)

Cc: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://patch.msgid.link/20260225164618.1261368-13-imre.deak@intel.com

Imre Deak 81e4161d 288b3c51

+10 -2
+10 -2
drivers/gpu/drm/i915/display/intel_dp.c
··· 5816 5816 return false; 5817 5817 } 5818 5818 5819 + /* 5820 + * Return %true if a full connector reprobe is required due to a failure while 5821 + * reading or acking the link service IRQs or if the reprobing is required 5822 + * after handling a link service IRQ event. 5823 + */ 5819 5824 static bool intel_dp_check_link_service_irq(struct intel_dp *intel_dp) 5820 5825 { 5821 5826 struct intel_display *display = to_intel_display(intel_dp); ··· 5831 5826 return false; 5832 5827 5833 5828 if (drm_dp_dpcd_readb(&intel_dp->aux, 5834 - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) 5829 + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1) 5830 + return true; 5831 + 5832 + if (!val) 5835 5833 return false; 5836 5834 5837 5835 if (drm_dp_dpcd_writeb(&intel_dp->aux, 5838 5836 DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) 5839 - return false; 5837 + return true; 5840 5838 5841 5839 if (val & RX_CAP_CHANGED) 5842 5840 reprobe_needed = true;