tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/i915/dsi: Make 'clock_stop' boolean

The DSI 'clock_stop' parameter is a boolean, so use a real
'bool' for it. And pimp the debug print while at it.

Note that we also remove the incorrect negation of the value
in the debug print. That has been there since the code was
introduced in commit 2ab8b458c6a1 ("drm/i915: Add support for
Generic MIPI panel driver"). An earlier version of the patch
https://lore.kernel.org/intel-gfx/1397454507-10273-5-git-send-email-shobhit.kumar@intel.com/
got it right, but looks like it got fumbled while dealing
with other review comments.

v2: Highlight the removal of the '!' (Jani)

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20260326111814.9800-4-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Ville Syrjälä 81ec9556 ca7fc6a8

+3 -3
+1 -1
drivers/gpu/drm/i915/display/intel_dsi.h
··· 81 81 int video_mode; 82 82 83 83 bool eot_pkt; 84 - u8 clock_stop; 84 + bool clock_stop; 85 85 86 86 u8 escape_clk_div; 87 87 u8 dual_link;
+2 -2
drivers/gpu/drm/i915/display/intel_dsi_vbt.c
··· 719 719 drm_printf(&p, "Burst mode ratio %d\n", intel_dsi->burst_mode_ratio); 720 720 drm_printf(&p, "Reset timer %d\n", intel_dsi->rst_timer_val); 721 721 drm_printf(&p, "EoT packet %s\n", str_enabled_disabled(intel_dsi->eot_pkt)); 722 - drm_printf(&p, "Clockstop %s\n", str_enabled_disabled(!intel_dsi->clock_stop)); 722 + drm_printf(&p, "Clock stop during BLLP %s\n", str_enabled_disabled(intel_dsi->clock_stop)); 723 723 drm_printf(&p, "Mode %s\n", intel_dsi->operation_mode ? "command" : "video"); 724 724 if (intel_dsi->dual_link == DSI_DUAL_LINK_FRONT_BACK) 725 725 drm_printf(&p, "Dual link: DSI_DUAL_LINK_FRONT_BACK\n"); ··· 771 771 drm_dbg_kms(display->drm, "\n"); 772 772 773 773 intel_dsi->eot_pkt = !mipi_config->eot_pkt_disabled; 774 - intel_dsi->clock_stop = mipi_config->enable_clk_stop ? 1 : 0; 774 + intel_dsi->clock_stop = mipi_config->enable_clk_stop; 775 775 intel_dsi->lane_count = mipi_config->lane_cnt + 1; 776 776 intel_dsi->pixel_format = 777 777 vbt_to_dsi_pixel_format(mipi_config->videomode_color_format);