tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: phy: qt2025: Fix hardware revision check comment

Correct the hardware revision check comment in the QT2025 driver. The
revision value was documented as 0x3b instead of the correct 0xb3,
which matches the actual comparison logic in the code.

Reviewed-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Trevor Gross <tmgross@umich.edu>
Link: https://patch.msgid.link/20250219-qt2025-comment-fix-v2-1-029f67696516@posteo.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Charalampos Mitrodimas and committed by
Jakub Kicinski 8279a8da ac8f0aff

+1 -1
+1 -1
drivers/net/phy/qt2025.rs
··· 41 41 42 42 fn probe(dev: &mut phy::Device) -> Result<()> { 43 43 // Check the hardware revision code. 44 - // Only 0x3b works with this driver and firmware. 44 + // Only 0xb3 works with this driver and firmware. 45 45 let hw_rev = dev.read(C45::new(Mmd::PMAPMD, 0xd001))?; 46 46 if (hw_rev >> 8) != 0xb3 { 47 47 return Err(code::ENODEV);