Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
lib/crypto: x86/blake2s: Use local labels for data
Following the usual practice, prefix the names of the data labels with
".L" so that the assembler treats them as truly local. This more
clearly expresses the intent and is less error-prone.
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20251102234209.62133-4-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
+26
-19
+26
-19
lib/crypto/x86/blake2s-core.S
+26
-19
lib/crypto/x86/blake2s-core.S
···
6
6
7
7
#include <linux/linkage.h>
8
8
9
-
.section .rodata.cst32.BLAKE2S_IV, "aM", @progbits, 32
9
+
.section .rodata.cst32.iv, "aM", @progbits, 32
10
10
.align 32
11
-
IV: .octa 0xA54FF53A3C6EF372BB67AE856A09E667
11
+
.Liv:
12
+
.octa 0xA54FF53A3C6EF372BB67AE856A09E667
12
13
.octa 0x5BE0CD191F83D9AB9B05688C510E527F
13
-
.section .rodata.cst16.ROT16, "aM", @progbits, 16
14
+
15
+
.section .rodata.cst16.ror16, "aM", @progbits, 16
14
16
.align 16
15
-
ROT16: .octa 0x0D0C0F0E09080B0A0504070601000302
16
-
.section .rodata.cst16.ROR328, "aM", @progbits, 16
17
+
.Lror16:
18
+
.octa 0x0D0C0F0E09080B0A0504070601000302
19
+
20
+
.section .rodata.cst16.ror8, "aM", @progbits, 16
17
21
.align 16
18
-
ROR328: .octa 0x0C0F0E0D080B0A090407060500030201
19
-
.section .rodata.cst64.BLAKE2S_SIGMA, "aM", @progbits, 160
22
+
.Lror8:
23
+
.octa 0x0C0F0E0D080B0A090407060500030201
24
+
25
+
.section .rodata.cst64.sigma, "aM", @progbits, 160
20
26
.align 64
21
-
SIGMA:
27
+
.Lsigma:
22
28
.byte 0, 2, 4, 6, 1, 3, 5, 7, 14, 8, 10, 12, 15, 9, 11, 13
23
29
.byte 14, 4, 9, 13, 10, 8, 15, 6, 5, 1, 0, 11, 3, 12, 2, 7
24
30
.byte 11, 12, 5, 15, 8, 0, 2, 13, 9, 10, 3, 7, 4, 14, 6, 1
···
35
29
.byte 13, 7, 12, 3, 11, 14, 1, 9, 2, 5, 15, 8, 10, 0, 4, 6
36
30
.byte 6, 14, 11, 0, 15, 9, 3, 8, 10, 12, 13, 1, 5, 2, 7, 4
37
31
.byte 10, 8, 7, 1, 2, 4, 6, 5, 13, 15, 9, 3, 0, 11, 14, 12
38
-
.section .rodata.cst64.BLAKE2S_SIGMA2, "aM", @progbits, 160
32
+
33
+
.section .rodata.cst64.sigma2, "aM", @progbits, 160
39
34
.align 64
40
-
SIGMA2:
35
+
.Lsigma2:
41
36
.byte 0, 2, 4, 6, 1, 3, 5, 7, 14, 8, 10, 12, 15, 9, 11, 13
42
37
.byte 8, 2, 13, 15, 10, 9, 12, 3, 6, 4, 0, 14, 5, 11, 1, 7
43
38
.byte 11, 13, 8, 6, 5, 10, 14, 3, 2, 4, 12, 15, 1, 0, 7, 9
···
54
47
SYM_FUNC_START(blake2s_compress_ssse3)
55
48
movdqu (%rdi),%xmm0
56
49
movdqu 0x10(%rdi),%xmm1
57
-
movdqa ROT16(%rip),%xmm12
58
-
movdqa ROR328(%rip),%xmm13
50
+
movdqa .Lror16(%rip),%xmm12
51
+
movdqa .Lror8(%rip),%xmm13
59
52
movdqu 0x20(%rdi),%xmm14
60
53
movd %ecx,%xmm15
61
-
leaq SIGMA+0xa0(%rip),%r8
54
+
leaq .Lsigma+0xa0(%rip),%r8
62
55
jmp .Lbeginofloop
63
56
.align 32
64
57
.Lbeginofloop:
65
58
movdqa %xmm0,%xmm10
66
59
movdqa %xmm1,%xmm11
67
60
paddq %xmm15,%xmm14
68
-
movdqa IV(%rip),%xmm2
61
+
movdqa .Liv(%rip),%xmm2
69
62
movdqa %xmm14,%xmm3
70
-
pxor IV+0x10(%rip),%xmm3
71
-
leaq SIGMA(%rip),%rcx
63
+
pxor .Liv+0x10(%rip),%xmm3
64
+
leaq .Lsigma(%rip),%rcx
72
65
.Lroundloop:
73
66
movzbl (%rcx),%eax
74
67
movd (%rsi,%rax,4),%xmm4
···
181
174
vmovdqu 0x10(%rdi),%xmm1
182
175
vmovdqu 0x20(%rdi),%xmm4
183
176
vmovd %ecx,%xmm5
184
-
vmovdqa IV(%rip),%xmm14
185
-
vmovdqa IV+16(%rip),%xmm15
177
+
vmovdqa .Liv(%rip),%xmm14
178
+
vmovdqa .Liv+16(%rip),%xmm15
186
179
jmp .Lblake2s_compress_avx512_mainloop
187
180
.align 32
188
181
.Lblake2s_compress_avx512_mainloop:
···
194
187
vmovdqu (%rsi),%ymm6
195
188
vmovdqu 0x20(%rsi),%ymm7
196
189
addq $0x40,%rsi
197
-
leaq SIGMA2(%rip),%rax
190
+
leaq .Lsigma2(%rip),%rax
198
191
movb $0xa,%cl
199
192
.Lblake2s_compress_avx512_roundloop:
200
193
vpmovzxbd (%rax),%ymm8