tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

spi: don't check spi_controller::num_chipselect when parsing a dt device

Do not validate spi_controller::num_chipselect against SPI_CS_CNT_MAX
when parsing an spi device firmware node.

Firstly this is the wrong place, and this should be done while
registering/validating the controller. Secondly, there is no reason for
that check, as SPI_CS_CNT_MAX controls the amount of chipselects a
device may have, not a controller may have.

So drop that check as it needlessly limits controllers to SPI_CS_CNT_MAX
number of chipselects.

Likewise, drop the check for number of device chipselects larger than
controller's number of chipselects, as __spi_add_device() will already
catch that as either one of the chip selects will be out of range, or
there is a duplicate one.

Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Link: https://patch.msgid.link/20250915183725.219473-6-jonas.gorski@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Jonas Gorski and committed by
Mark Brown 83c522fb f3982dac

+1 -10
+1 -10
drivers/spi/spi.c
··· 2427 2427 return 0; 2428 2428 } 2429 2429 2430 - if (ctlr->num_chipselect > SPI_CS_CNT_MAX) { 2431 - dev_err(&ctlr->dev, "No. of CS is more than max. no. of supported CS\n"); 2432 - return -EINVAL; 2433 - } 2434 - 2435 2430 /* Device address */ 2436 2431 rc = of_property_read_variable_u32_array(nc, "reg", &cs[0], 1, 2437 2432 SPI_CS_CNT_MAX); ··· 2435 2440 nc, rc); 2436 2441 return rc; 2437 2442 } 2438 - if (rc > ctlr->num_chipselect) { 2439 - dev_err(&ctlr->dev, "%pOF has number of CS > ctlr->num_chipselect (%d)\n", 2440 - nc, rc); 2441 - return -EINVAL; 2442 - } 2443 + 2443 2444 if ((of_property_present(nc, "parallel-memories")) && 2444 2445 (!(ctlr->flags & SPI_CONTROLLER_MULTI_CS))) { 2445 2446 dev_err(&ctlr->dev, "SPI controller doesn't support multi CS\n");