tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

gve: Fix gve interrupt names

IRQs are currently requested before the netdevice is registered
and a proper name is assigned to the device. Changing interrupt
name to avoid using the format string in the name.

Interrupt name before change: eth%d-ntfy-block.<blk_id>
Interrupt name after change: gve-ntfy-blk<blk_id>@pci:<pci_name>

Signed-off-by: Praveen Kaligineedi <pkaligineedi@google.com>
Reviewed-by: Jeroen de Borst <jeroendb@google.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Praveen Kaligineedi and committed by
David S. Miller 84371145 d78f8d83

+4 -5
+4 -5
drivers/net/ethernet/google/gve/gve_main.c
··· 327 327 static int gve_alloc_notify_blocks(struct gve_priv *priv) 328 328 { 329 329 int num_vecs_requested = priv->num_ntfy_blks + 1; 330 - char *name = priv->dev->name; 331 330 unsigned int active_cpus; 332 331 int vecs_enabled; 333 332 int i, j; ··· 370 371 active_cpus = min_t(int, priv->num_ntfy_blks / 2, num_online_cpus()); 371 372 372 373 /* Setup Management Vector - the last vector */ 373 - snprintf(priv->mgmt_msix_name, sizeof(priv->mgmt_msix_name), "%s-mgmnt", 374 - name); 374 + snprintf(priv->mgmt_msix_name, sizeof(priv->mgmt_msix_name), "gve-mgmnt@pci:%s", 375 + pci_name(priv->pdev)); 375 376 err = request_irq(priv->msix_vectors[priv->mgmt_msix_idx].vector, 376 377 gve_mgmnt_intr, 0, priv->mgmt_msix_name, priv); 377 378 if (err) { ··· 400 401 struct gve_notify_block *block = &priv->ntfy_blocks[i]; 401 402 int msix_idx = i; 402 403 403 - snprintf(block->name, sizeof(block->name), "%s-ntfy-block.%d", 404 - name, i); 404 + snprintf(block->name, sizeof(block->name), "gve-ntfy-blk%d@pci:%s", 405 + i, pci_name(priv->pdev)); 405 406 block->priv = priv; 406 407 err = request_irq(priv->msix_vectors[msix_idx].vector, 407 408 gve_is_gqi(priv) ? gve_intr : gve_intr_dqo,