tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ASoC: SOF: Disable pointless writes to debugfs file

The permissions on this debugfs file are 0444 so it can't be written to.
And writing to the file hasn't done anything since commit 6e9548cdb30e
("ASoC: SOF: Convert the generic IPC flood test into SOF client").
Delete the write function.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://msgid.link/r/9d2477cf-25aa-4d12-818f-fdafc9aaa28a@moroto.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Dan Carpenter and committed by
Mark Brown 84ae7d9c 98b1bb9e

-19
-19
sound/soc/sof/debug.c
··· 19 19 #include "sof-priv.h" 20 20 #include "ops.h" 21 21 22 - static ssize_t sof_dfsentry_write(struct file *file, const char __user *buffer, 23 - size_t count, loff_t *ppos) 24 - { 25 - size_t size; 26 - char *string; 27 - int ret; 28 - 29 - string = kzalloc(count+1, GFP_KERNEL); 30 - if (!string) 31 - return -ENOMEM; 32 - 33 - size = simple_write_to_buffer(string, count, ppos, buffer, count); 34 - ret = size; 35 - 36 - kfree(string); 37 - return ret; 38 - } 39 - 40 22 static ssize_t sof_dfsentry_read(struct file *file, char __user *buffer, 41 23 size_t count, loff_t *ppos) 42 24 { ··· 108 126 .open = simple_open, 109 127 .read = sof_dfsentry_read, 110 128 .llseek = default_llseek, 111 - .write = sof_dfsentry_write, 112 129 }; 113 130 114 131 /* create FS entry for debug files that can expose DSP memories, registers */