Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ntfs3: fix OOB write in attr_wof_frame_info()

In attr_wof_frame_info(), the offset-table read range for a nonresident
WofCompressedData stream is:

u64 from = vbo[i] & ~(u64)(PAGE_SIZE - 1);
u64 to = min(from + PAGE_SIZE, wof_size);
...
ntfs_read_run(sbi, run, addr, from, to - from);

A crafted image sets WofCompressedData.nres.data_size to 0xfff while the
file is large enough to request frame 1024 (offset 0x400000). This gives
from=0x1000, to=0xfff. The unsigned (to - from) wraps to 0xffffffffffffffff
and ntfs_read_write_run() overflows the single-page offs_folio via memcpy.

Triggered by pread() on a mounted NTFS image. Depending on adjacent
memory layout at the time of the overflow, KASAN reports this as
slab-out-of-bounds, use-after-free, or slab-use-after-free all at
ntfs_read_write_run(). Secondary corruption/panic paths were also observed.

Reject the read when the offset-table page is outside the stream.

Signed-off-by: 0xkato <0xkkato@gmail.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>

authored by

0xkato and committed by
Konstantin Komarov
859d7776 87ac077d

+6
+6
fs/ntfs3/attrib.c
··· 1591 1591 u64 from = vbo[i] & ~(u64)(PAGE_SIZE - 1); 1592 1592 u64 to = min(from + PAGE_SIZE, wof_size); 1593 1593 1594 + if (from >= wof_size) { 1595 + _ntfs_bad_inode(&ni->vfs_inode); 1596 + err = -EINVAL; 1597 + goto out1; 1598 + } 1599 + 1594 1600 err = attr_load_runs_range(ni, ATTR_DATA, WOF_NAME, 1595 1601 ARRAY_SIZE(WOF_NAME), run, 1596 1602 from, to);