tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

watchdog: at91sam9: Stop using module_platform_driver_probe()

On today's platforms the benefit of platform_driver_probe() isn't that
relevant any more. It allows to drop some code after booting (or module
loading) for .probe() and discard the .remove() function completely if
the driver is built-in. This typically saves a few 100k.

The downside of platform_driver_probe() is that the driver cannot be
bound and unbound at runtime which is ancient and also slightly
complicates testing. There are also thoughts to deprecate
platform_driver_probe() because it adds some complexity in the driver
core for little gain. Also many drivers don't use it correctly. This
driver for example misses to mark the driver struct with __refdata which
is needed to suppress a (W=1) modpost warning:

WARNING: modpost: drivers/watchdog/at91sam9_wdt: section mismatch in reference: at91wdt_driver+0x4 (section: .data) -> at91wdt_remove (section: .exit.text)

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20231106154807.3866712-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>

authored by

Uwe Kleine-König and committed by
Wim Van Sebroeck 86aa2919 dc805ea0

+5 -5
+5 -5
drivers/watchdog/at91sam9_wdt.c
··· 324 324 } 325 325 #endif 326 326 327 - static int __init at91wdt_probe(struct platform_device *pdev) 327 + static int at91wdt_probe(struct platform_device *pdev) 328 328 { 329 329 int err; 330 330 struct at91wdt *wdt; ··· 372 372 return 0; 373 373 } 374 374 375 - static int __exit at91wdt_remove(struct platform_device *pdev) 375 + static int at91wdt_remove(struct platform_device *pdev) 376 376 { 377 377 struct at91wdt *wdt = platform_get_drvdata(pdev); 378 378 watchdog_unregister_device(&wdt->wdd); ··· 393 393 #endif 394 394 395 395 static struct platform_driver at91wdt_driver = { 396 - .remove = __exit_p(at91wdt_remove), 396 + .probe = at91wdt_probe, 397 + .remove = at91wdt_remove, 397 398 .driver = { 398 399 .name = "at91_wdt", 399 400 .of_match_table = of_match_ptr(at91_wdt_dt_ids), 400 401 }, 401 402 }; 402 - 403 - module_platform_driver_probe(at91wdt_driver, at91wdt_probe); 403 + module_platform_driver(at91wdt_driver); 404 404 405 405 MODULE_AUTHOR("Renaud CERRATO <r.cerrato@til-technologies.fr>"); 406 406 MODULE_DESCRIPTION("Watchdog driver for Atmel AT91SAM9x processors");