Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

video: fbdev: aty: aty128fb: Replace mdelay with msleep in aty128_set_suspend

aty128_set_suspend() is never called in atomic context.

The call chains ending up at aty128_set_suspend() are:
[1] aty128_set_suspend() <- aty128_pci_suspend()
[2] aty128_set_suspend() <- aty128_do_resume() <- aty128_pci_resume()
[3] aty128_set_suspend() <- aty128_do_resume() <- aty128_early_resume()

aty128_pci_suspend() is set as ".suspend" in struct pci_driver.
aty128_pci_resume() is set as ".resume" in struct pci_driver.
aty128_early_resume() is never called.
These functions are not called in atomic context.

Despite never getting called from atomic context, aty128_set_suspend()
calls mdelay() to busily wait.
This is not necessary and can be replaced with msleep() to
avoid busy waiting.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

authored by

Jia-Ju Bai and committed by
Bartlomiej Zolnierkiewicz
86c4e7c3 12f3ac2f

+1 -1
+1 -1
drivers/video/fbdev/aty/aty128fb.c
··· 2442 2442 (void)aty_ld_pll(POWER_MANAGEMENT); 2443 2443 aty_st_le32(BUS_CNTL1, 0x00000010); 2444 2444 aty_st_le32(MEM_POWER_MISC, 0x0c830000); 2445 - mdelay(100); 2445 + msleep(100); 2446 2446 2447 2447 /* Switch PCI power management to D2 */ 2448 2448 pci_set_power_state(pdev, PCI_D2);