Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

usb: typec: tcpm: print error on hard reset

A USB-C hard reset involves removing the voltage from VBUS for some
time. So basically it has the same effect as removing the USB-C plug
for a short moment. If the machine is powered from the USB-C port and
does not have a fallback supply (e.g. a battery), this will result in
a full machine reset due to power loss.

Ideally we want to avoid triggering a hard reset on these boards. A
non-working USB-C port is probably better than unplanned reboots. But
boards with a backup supply should do the hard reset to get everything
working again.

In theory it would be enough to check the self_powered property, but
it seems the property might not be configured consistently enough in
system firmwares.

So let's start with just printing an error message when a hard reset is
triggered on systems we expect to be affected. This at least makes
debugging issues on affected systems easier without impacting unaffected
systems too much.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20240523171645.223225-1-sebastian.reichel@collabora.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Sebastian Reichel and committed by
Greg Kroah-Hartman
876483a5 122968f8

+2
+2
drivers/usb/typec/tcpm/tcpm.c
··· 5208 5208 case HARD_RESET_SEND: 5209 5209 if (port->ams != NONE_AMS) 5210 5210 tcpm_ams_finish(port); 5211 + if (!port->self_powered && port->port_type == TYPEC_PORT_SNK) 5212 + dev_err(port->dev, "Initiating hard-reset, which might result in machine power-loss.\n"); 5211 5213 /* 5212 5214 * State machine will be directed to HARD_RESET_START, 5213 5215 * thus set upcoming_state to INVALID_STATE.