Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

usb: ljca: Improve ACPI hardware ID documentation

Document the differences between the LJCA client device ACPI hardware IDs,
including the USBIO IDs used for LJCA devices.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Hans de Goede <hansg@kernel.org>
Link: https://lore.kernel.org/r/20251010055625.4147844-2-sakari.ailus@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Sakari Ailus and committed by
Greg Kroah-Hartman
877c80df 9f0b086c

+24 -13
+24 -13
drivers/usb/misc/usb-ljca.c
··· 164 164 struct acpi_device *adev; 165 165 }; 166 166 167 + /* 168 + * ACPI hardware IDs for LJCA client devices. 169 + * 170 + * [1] Some BIOS implementations use these IDs for denoting LJCA client devices 171 + * even though the IDs have been allocated for USBIO. This isn't a problem 172 + * as the usb-ljca driver is probed based on the USB device's vendor and 173 + * product IDs and its client drivers are probed based on auxiliary device 174 + * names, not these ACPI _HIDs. List of such systems: 175 + * 176 + * Dell Precision 5490 177 + */ 167 178 static const struct acpi_device_id ljca_gpio_hids[] = { 168 - { "INTC100B" }, 169 - { "INTC1074" }, 170 - { "INTC1096" }, 171 - { "INTC10B5" }, 172 - { "INTC10D1" }, 179 + { "INTC100B" }, /* RPL LJCA GPIO */ 180 + { "INTC1074" }, /* CVF LJCA GPIO */ 181 + { "INTC1096" }, /* ADL LJCA GPIO */ 182 + { "INTC10B5" }, /* LNL LJCA GPIO */ 183 + { "INTC10D1" }, /* MTL (CVF VSC) USBIO GPIO [1] */ 173 184 {}, 174 185 }; 175 186 176 187 static const struct acpi_device_id ljca_i2c_hids[] = { 177 - { "INTC100C" }, 178 - { "INTC1075" }, 179 - { "INTC1097" }, 180 - { "INTC10D2" }, 188 + { "INTC100C" }, /* RPL LJCA I2C */ 189 + { "INTC1075" }, /* CVF LJCA I2C */ 190 + { "INTC1097" }, /* ADL LJCA I2C */ 191 + { "INTC10D2" }, /* MTL (CVF VSC) USBIO I2C [1] */ 181 192 {}, 182 193 }; 183 194 184 195 static const struct acpi_device_id ljca_spi_hids[] = { 185 - { "INTC100D" }, 186 - { "INTC1091" }, 187 - { "INTC1098" }, 188 - { "INTC10D3" }, 196 + { "INTC100D" }, /* RPL LJCA SPI */ 197 + { "INTC1091" }, /* TGL/ADL LJCA SPI */ 198 + { "INTC1098" }, /* ADL LJCA SPI */ 199 + { "INTC10D3" }, /* MTL (CVF VSC) USBIO SPI [1] */ 189 200 {}, 190 201 }; 191 202