tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

block, bfq: remove unnecessary goto tag in bfq_dispatch_rq_from_bfqq

We jump to tag only for returning current rq. Return directly to
remove this tag.

Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Link: https://lore.kernel.org/r/20230116095153.3810101-8-shikemeng@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>

authored by

Kemeng Shi and committed by
Jens Axboe 87c971de 433d4b03

+3 -6
+3 -6
block/bfq-iosched.c
··· 5120 5120 bfq_dispatch_remove(bfqd->queue, rq); 5121 5121 5122 5122 if (bfqq != bfqd->in_service_queue) 5123 - goto return_rq; 5123 + return rq; 5124 5124 5125 5125 /* 5126 5126 * If weight raising has to terminate for bfqq, then next ··· 5140 5140 * belongs to CLASS_IDLE and other queues are waiting for 5141 5141 * service. 5142 5142 */ 5143 - if (!(bfq_tot_busy_queues(bfqd) > 1 && bfq_class_idle(bfqq))) 5144 - goto return_rq; 5143 + if (bfq_tot_busy_queues(bfqd) > 1 && bfq_class_idle(bfqq)) 5144 + bfq_bfqq_expire(bfqd, bfqq, false, BFQQE_BUDGET_EXHAUSTED); 5145 5145 5146 - bfq_bfqq_expire(bfqd, bfqq, false, BFQQE_BUDGET_EXHAUSTED); 5147 - 5148 - return_rq: 5149 5146 return rq; 5150 5147 } 5151 5148