tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

fbdev: vt8500lcdfb: fix missing dma_free_coherent()

fbi->fb.screen_buffer is allocated with dma_alloc_coherent() but is not
freed if the error path is reached.

Fixes: e7b995371fe1 ("video: vt8500: Add devicetree support for vt8500-fb and wm8505-fb")
Cc: <stable@vger.kernel.org>
Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>

authored by

Thomas Fourier and committed by
Helge Deller 88b3b992 994fcd4b

+4 -1
+4 -1
drivers/video/fbdev/vt8500lcdfb.c
··· 369 369 if (fbi->palette_cpu == NULL) { 370 370 dev_err(&pdev->dev, "Failed to allocate palette buffer\n"); 371 371 ret = -ENOMEM; 372 - goto failed_free_io; 372 + goto failed_free_mem_virt; 373 373 } 374 374 375 375 irq = platform_get_irq(pdev, 0); ··· 432 432 failed_free_palette: 433 433 dma_free_coherent(&pdev->dev, fbi->palette_size, 434 434 fbi->palette_cpu, fbi->palette_phys); 435 + failed_free_mem_virt: 436 + dma_free_coherent(&pdev->dev, fbi->fb.fix.smem_len, 437 + fbi->fb.screen_buffer, fbi->fb.fix.smem_start); 435 438 failed_free_io: 436 439 iounmap(fbi->regbase); 437 440 failed_free_res: