tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Revert "floppy: fix reference leak on platform_device_register() failure"

This reverts commit e784f2ea0b4fd0e7b70028ff8218f22456c5dcf8.

Jiri says the patch is buggy, and it looks like he is right revert it
for now.

Link: https://lore.kernel.org/linux-block/897f442d-4e04-4b70-b716-38fd10b8af36@kernel.org/
Reported-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

Jens Axboe 895a9b37 309e02dc

+3 -7
+3 -7
drivers/block/floppy.c
··· 4722 4722 floppy_device[drive].dev.groups = floppy_dev_groups; 4723 4723 4724 4724 err = platform_device_register(&floppy_device[drive]); 4725 - if (err) { 4726 - platform_device_put(&floppy_device[drive]); 4725 + if (err) 4727 4726 goto out_remove_drives; 4728 - } 4727 + 4729 4728 registered[drive] = true; 4730 4729 4731 4730 err = device_add_disk(&floppy_device[drive].dev, 4732 4731 disks[drive][0], NULL); 4733 - if (err) { 4734 - platform_device_unregister(&floppy_device[drive]); 4735 - registered[drive] = false; 4732 + if (err) 4736 4733 goto out_remove_drives; 4737 - } 4738 4734 } 4739 4735 4740 4736 return 0;