tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mailbox: remove superfluous internal header

Quite some controller drivers use the defines from the internal header
already. This prevents controller drivers outside the mailbox directory.
Move the defines to the public controller header to allow this again as
the defines are not strictly internal anyhow.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Sudeep Holla <sudeep.holla@kernel.org>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>

authored by

Wolfram Sang and committed by
Jassi Brar 89e5d7d6 d81e6703

+5 -28
-2
drivers/mailbox/cix-mailbox.c
··· 12 12 #include <linux/module.h> 13 13 #include <linux/platform_device.h> 14 14 15 - #include "mailbox.h" 16 - 17 15 /* 18 16 * The maximum transmission size is 32 words or 128 bytes. 19 17 */
-2
drivers/mailbox/hi3660-mailbox.c
··· 15 15 #include <linux/platform_device.h> 16 16 #include <linux/slab.h> 17 17 18 - #include "mailbox.h" 19 - 20 18 #define MBOX_CHAN_MAX 32 21 19 22 20 #define MBOX_RX 0x0
-2
drivers/mailbox/imx-mailbox.c
··· 23 23 #include <linux/slab.h> 24 24 #include <linux/workqueue.h> 25 25 26 - #include "mailbox.h" 27 - 28 26 #define IMX_MU_CHANS 24 29 27 /* TX0/RX0/RXDB[0-3] */ 30 28 #define IMX_MU_SCU_CHANS 6
-2
drivers/mailbox/mailbox-sti.c
··· 21 21 #include <linux/property.h> 22 22 #include <linux/slab.h> 23 23 24 - #include "mailbox.h" 25 - 26 24 #define STI_MBOX_INST_MAX 4 /* RAM saving: Max supported instances */ 27 25 #define STI_MBOX_CHAN_MAX 20 /* RAM saving: Max supported channels */ 28 26
-2
drivers/mailbox/mailbox.c
··· 18 18 #include <linux/property.h> 19 19 #include <linux/spinlock.h> 20 20 21 - #include "mailbox.h" 22 - 23 21 static LIST_HEAD(mbox_cons); 24 22 static DEFINE_MUTEX(con_mutex); 25 23
-12
drivers/mailbox/mailbox.h
··· 1 - /* SPDX-License-Identifier: GPL-2.0-only */ 2 - 3 - #ifndef __MAILBOX_H 4 - #define __MAILBOX_H 5 - 6 - #include <linux/bits.h> 7 - 8 - #define TXDONE_BY_IRQ BIT(0) /* controller has remote RTR irq */ 9 - #define TXDONE_BY_POLL BIT(1) /* controller can read status of last TX */ 10 - #define TXDONE_BY_ACK BIT(2) /* S/W ACK received by Client ticks the TX */ 11 - 12 - #endif /* __MAILBOX_H */
-2
drivers/mailbox/omap-mailbox.c
··· 22 22 #include <linux/pm_runtime.h> 23 23 #include <linux/mailbox_controller.h> 24 24 25 - #include "mailbox.h" 26 - 27 25 #define MAILBOX_REVISION 0x000 28 26 #define MAILBOX_MESSAGE(m) (0x040 + 4 * (m)) 29 27 #define MAILBOX_FIFOSTATUS(m) (0x080 + 4 * (m))
-2
drivers/mailbox/pcc.c
··· 59 59 #include <linux/io-64-nonatomic-lo-hi.h> 60 60 #include <acpi/pcc.h> 61 61 62 - #include "mailbox.h" 63 - 64 62 #define MBOX_IRQ_NAME "pcc-mbox" 65 63 66 64 /**
-2
drivers/mailbox/tegra-hsp.c
··· 16 16 17 17 #include <dt-bindings/mailbox/tegra186-hsp.h> 18 18 19 - #include "mailbox.h" 20 - 21 19 #define HSP_INT_IE(x) (0x100 + ((x) * 4)) 22 20 #define HSP_INT_IV 0x300 23 21 #define HSP_INT_IR 0x304
+5
include/linux/mailbox_controller.h
··· 3 3 #ifndef __MAILBOX_CONTROLLER_H 4 4 #define __MAILBOX_CONTROLLER_H 5 5 6 + #include <linux/bits.h> 6 7 #include <linux/completion.h> 7 8 #include <linux/device.h> 8 9 #include <linux/hrtimer.h> ··· 11 10 #include <linux/types.h> 12 11 13 12 struct mbox_chan; 13 + 14 + #define TXDONE_BY_IRQ BIT(0) /* controller has remote RTR irq */ 15 + #define TXDONE_BY_POLL BIT(1) /* controller can read status of last TX */ 16 + #define TXDONE_BY_ACK BIT(2) /* S/W ACK received by Client ticks the TX */ 14 17 15 18 /** 16 19 * struct mbox_chan_ops - methods to control mailbox channels