Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: freescale: Discard pm_runtime_put() return value

Printing error messages on pm_runtime_put() returning negative values
is not particularly useful.

Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example.

Accordingly, update mixel_lvds_phy_reset() to simply discard the return
value of pm_runtime_put().

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/2012926.taCxCBeP46@rafael.j.wysocki
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Rafael J. Wysocki and committed by
Vinod Koul
8bb108e4 8a203b05

+2 -4
+2 -4
drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c
··· 286 286 287 287 regmap_write(priv->regmap, PHY_CTRL, CTRL_RESET_VAL); 288 288 289 - ret = pm_runtime_put(dev); 290 - if (ret < 0) 291 - dev_err(dev, "failed to put PM runtime: %d\n", ret); 289 + pm_runtime_put(dev); 292 290 293 - return ret; 291 + return 0; 294 292 } 295 293 296 294 static struct phy *mixel_lvds_phy_xlate(struct device *dev,