Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

i2c: testunit: Replace system_long_wq with system_dfl_long_wq

Currently the code enqueue work items using {queue|mod}_delayed_work(),
using system_long_wq. This workqueue should be used when long works are
expected, but it is a per-cpu workqueue.

This is important because queue_delayed_work() queue the work using:

queue_delayed_work_on(WORK_CPU_UNBOUND, ...);

Note that WORK_CPU_UNBOUND = NR_CPUS.

This would end up calling __queue_delayed_work() that does:

if (housekeeping_enabled(HK_TYPE_TIMER)) {
// [....]
} else {
if (likely(cpu == WORK_CPU_UNBOUND))
add_timer_global(timer);
else
add_timer_on(timer, cpu);
}

So when cpu == WORK_CPU_UNBOUND the timer is global and is
not using a specific CPU. Later, when __queue_work() is called:

if (req_cpu == WORK_CPU_UNBOUND) {
if (wq->flags & WQ_UNBOUND)
cpu = wq_select_unbound_cpu(raw_smp_processor_id());
else
cpu = raw_smp_processor_id();
}

Because the wq is not unbound, it takes the CPU where the timer
fired and enqueue the work on that CPU.
The consequence of all of this is that the work can run anywhere,
depending on where the timer fired.

Recently, a new unbound workqueue specific for long running work has
been added:

c116737e972e ("workqueue: Add system_dfl_long_wq for long unbound works")

So change system_long_wq with system_dfl_long_wq so that the work may
benefit from scheduler task placement.

Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
[wsa: remove FIXME as well]
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

authored by

Marco Crivellari and committed by
Wolfram Sang
8bc6b14a 7fd2df20

+2 -2
+2 -2
drivers/i2c/i2c-slave-testunit.c
··· 15 15 #include <linux/module.h> 16 16 #include <linux/of.h> 17 17 #include <linux/slab.h> 18 - #include <linux/workqueue.h> /* FIXME: is system_long_wq the best choice? */ 18 + #include <linux/workqueue.h> 19 19 20 20 #define TU_VERSION_MAX_LENGTH 128 21 21 ··· 124 124 case I2C_SLAVE_STOP: 125 125 if (tu->reg_idx == TU_NUM_REGS) { 126 126 set_bit(TU_FLAG_IN_PROCESS, &tu->flags); 127 - queue_delayed_work(system_long_wq, &tu->worker, 127 + queue_delayed_work(system_dfl_long_wq, &tu->worker, 128 128 msecs_to_jiffies(10 * tu->regs[TU_REG_DELAY])); 129 129 } 130 130