tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: fsl-imx8mq-usb: Clear the PCS_TX_SWING_FULL field before using it

Clear the PCS_TX_SWING_FULL field mask before setting the new value
in PHY_CTRL5 register. Without clearing the mask first, the OR operation
could leave previously set bits, resulting in incorrect register
configuration.

Fixes: 63c85ad0cd81 ("phy: fsl-imx8mp-usb: add support for phy tuning")
Suggested-by: Leonid Segal <leonids@variscite.com>
Acked-by: Pierluigi Passaro <pierluigi.p@variscite.com>
Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
Reviewed-by: Xu Yang <xu.yang_2@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Link: https://patch.msgid.link/20251219160912.561431-1-stefano.r@variscite.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Stefano Radaelli and committed by
Vinod Koul 8becf917 393e132e

+1
+1
drivers/phy/freescale/phy-fsl-imx8mq-usb.c
··· 490 490 491 491 if (imx_phy->pcs_tx_swing_full != PHY_TUNE_DEFAULT) { 492 492 value = readl(imx_phy->base + PHY_CTRL5); 493 + value &= ~PHY_CTRL5_PCS_TX_SWING_FULL_MASK; 493 494 value |= FIELD_PREP(PHY_CTRL5_PCS_TX_SWING_FULL_MASK, 494 495 imx_phy->pcs_tx_swing_full); 495 496 writel(value, imx_phy->base + PHY_CTRL5);