Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

RDMA: Remove redundant = {} for udata req structs

Now that all of the udata request structs are loaded with the helpers
the callers should not pre-zero them. The helpers all guarantee that
the entire struct is filled with something.

Reviewed-by: Long Li <longli@microsoft.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>

authored by

Jason Gunthorpe and committed by
Leon Romanovsky
8e3e07cc 69309e17

+21 -19
+2 -2
drivers/infiniband/hw/efa/efa_verbs.c
··· 682 682 struct efa_com_create_qp_result create_qp_resp; 683 683 struct efa_dev *dev = to_edev(ibqp->device); 684 684 struct efa_ibv_create_qp_resp resp = {}; 685 - struct efa_ibv_create_qp cmd = {}; 685 + struct efa_ibv_create_qp cmd; 686 686 struct efa_qp *qp = to_eqp(ibqp); 687 687 struct efa_ucontext *ucontext; 688 688 u16 supported_efa_flags = 0; ··· 1121 1121 struct efa_com_create_cq_result result; 1122 1122 struct ib_device *ibdev = ibcq->device; 1123 1123 struct efa_dev *dev = to_edev(ibdev); 1124 - struct efa_ibv_create_cq cmd = {}; 1124 + struct efa_ibv_create_cq cmd; 1125 1125 struct efa_cq *cq = to_ecq(ibcq); 1126 1126 int entries = attr->cqe; 1127 1127 bool set_src_addr;
+1 -1
drivers/infiniband/hw/hns/hns_roce_main.c
··· 425 425 struct hns_roce_ucontext *context = to_hr_ucontext(uctx); 426 426 struct hns_roce_dev *hr_dev = to_hr_dev(uctx->device); 427 427 struct hns_roce_ib_alloc_ucontext_resp resp = {}; 428 - struct hns_roce_ib_alloc_ucontext ucmd = {}; 428 + struct hns_roce_ib_alloc_ucontext ucmd; 429 429 int ret = -EAGAIN; 430 430 431 431 if (!hr_dev->active)
+1 -1
drivers/infiniband/hw/hns/hns_roce_srq.c
··· 406 406 struct ib_udata *udata, 407 407 struct hns_roce_ib_create_srq_resp *resp) 408 408 { 409 - struct hns_roce_ib_create_srq ucmd = {}; 409 + struct hns_roce_ib_create_srq ucmd; 410 410 struct hns_roce_ucontext *uctx; 411 411 int ret; 412 412
+1 -1
drivers/infiniband/hw/mana/cq.c
··· 13 13 struct mana_ib_create_cq_resp resp = {}; 14 14 struct mana_ib_ucontext *mana_ucontext; 15 15 struct ib_device *ibdev = ibcq->device; 16 - struct mana_ib_create_cq ucmd = {}; 16 + struct mana_ib_create_cq ucmd; 17 17 struct mana_ib_dev *mdev; 18 18 bool is_rnic_cq; 19 19 u32 doorbell;
+1 -1
drivers/infiniband/hw/mana/qp.c
··· 81 81 container_of(pd->device, struct mana_ib_dev, ib_dev); 82 82 struct ib_rwq_ind_table *ind_tbl = attr->rwq_ind_tbl; 83 83 struct mana_ib_create_qp_rss_resp resp = {}; 84 - struct mana_ib_create_qp_rss ucmd = {}; 84 + struct mana_ib_create_qp_rss ucmd; 85 85 mana_handle_t *mana_ind_table; 86 86 struct mana_port_context *mpc; 87 87 unsigned int ind_tbl_size;
+1 -1
drivers/infiniband/hw/mana/wq.c
··· 11 11 { 12 12 struct mana_ib_dev *mdev = 13 13 container_of(pd->device, struct mana_ib_dev, ib_dev); 14 - struct mana_ib_create_wq ucmd = {}; 14 + struct mana_ib_create_wq ucmd; 15 15 struct mana_ib_wq *wq; 16 16 int err; 17 17
+2 -2
drivers/infiniband/hw/mlx4/qp.c
··· 709 709 struct ib_qp_init_attr *init_attr, 710 710 struct ib_udata *udata) 711 711 { 712 - struct mlx4_ib_create_qp_rss ucmd = {}; 712 + struct mlx4_ib_create_qp_rss ucmd; 713 713 int err; 714 714 715 715 if (!udata) { ··· 4230 4230 u32 wq_attr_mask, struct ib_udata *udata) 4231 4231 { 4232 4232 struct mlx4_ib_qp *qp = to_mqp((struct ib_qp *)ibwq); 4233 - struct mlx4_ib_modify_wq ucmd = {}; 4233 + struct mlx4_ib_modify_wq ucmd; 4234 4234 enum ib_wq_state cur_state, new_state; 4235 4235 int err; 4236 4236
+1 -1
drivers/infiniband/hw/mlx5/cq.c
··· 720 720 int *cqe_size, int *index, int *inlen, 721 721 struct uverbs_attr_bundle *attrs) 722 722 { 723 - struct mlx5_ib_create_cq ucmd = {}; 723 + struct mlx5_ib_create_cq ucmd; 724 724 unsigned long page_size; 725 725 unsigned int page_offset_quantized; 726 726 __be64 *pas;
+1 -1
drivers/infiniband/hw/mlx5/main.c
··· 2178 2178 { 2179 2179 struct ib_device *ibdev = uctx->device; 2180 2180 struct mlx5_ib_dev *dev = to_mdev(ibdev); 2181 - struct mlx5_ib_alloc_ucontext_req_v2 req = {}; 2181 + struct mlx5_ib_alloc_ucontext_req_v2 req; 2182 2182 struct mlx5_ib_alloc_ucontext_resp resp = {}; 2183 2183 struct mlx5_ib_ucontext *context = to_mucontext(uctx); 2184 2184 struct mlx5_bfreg_info *bfregi;
+2 -2
drivers/infiniband/hw/mlx5/qp.c
··· 4692 4692 struct mlx5_ib_dev *dev = to_mdev(ibqp->device); 4693 4693 struct mlx5_ib_modify_qp_resp resp = {}; 4694 4694 struct mlx5_ib_qp *qp = to_mqp(ibqp); 4695 - struct mlx5_ib_modify_qp ucmd = {}; 4695 + struct mlx5_ib_modify_qp ucmd; 4696 4696 enum ib_qp_type qp_type; 4697 4697 enum ib_qp_state cur_state, new_state; 4698 4698 int err = -EINVAL; ··· 5379 5379 struct mlx5_ib_rwq *rwq) 5380 5380 { 5381 5381 struct mlx5_ib_dev *dev = to_mdev(pd->device); 5382 - struct mlx5_ib_create_wq ucmd = {}; 5382 + struct mlx5_ib_create_wq ucmd; 5383 5383 int err; 5384 5384 5385 5385 err = ib_copy_validate_udata_in_cm(udata, ucmd,
+1 -1
drivers/infiniband/hw/mlx5/srq.c
··· 45 45 struct ib_udata *udata, int buf_size) 46 46 { 47 47 struct mlx5_ib_dev *dev = to_mdev(pd->device); 48 - struct mlx5_ib_create_srq ucmd = {}; 48 + struct mlx5_ib_create_srq ucmd; 49 49 struct mlx5_ib_ucontext *ucontext = rdma_udata_to_drv_context( 50 50 udata, struct mlx5_ib_ucontext, ibucontext); 51 51 int err;
+3 -1
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
··· 1308 1308 if (status) 1309 1309 goto gen_err; 1310 1310 1311 - memset(&ureq, 0, sizeof(ureq)); 1312 1311 if (udata) { 1313 1312 status = ib_copy_validate_udata_in(udata, ureq, rsvd1); 1314 1313 if (status) 1315 1314 return status; 1315 + } else { 1316 + memset(&ureq, 0, sizeof(ureq)); 1316 1317 } 1318 + 1317 1319 ocrdma_set_qp_init_params(qp, pd, attrs); 1318 1320 if (udata == NULL) 1319 1321 qp->cap_flags |= (OCRDMA_QP_MW_BIND | OCRDMA_QP_LKEY0 |
+4 -4
drivers/infiniband/hw/qedr/verbs.c
··· 264 264 int rc; 265 265 struct qedr_ucontext *ctx = get_qedr_ucontext(uctx); 266 266 struct qedr_alloc_ucontext_resp uresp = {}; 267 - struct qedr_alloc_ucontext_req ureq = {}; 267 + struct qedr_alloc_ucontext_req ureq; 268 268 struct qedr_dev *dev = get_qedr_dev(ibdev); 269 269 struct qed_rdma_add_user_out_params oparams; 270 270 struct qedr_user_mmap_entry *entry; ··· 913 913 }; 914 914 struct qedr_dev *dev = get_qedr_dev(ibdev); 915 915 struct qed_rdma_create_cq_in_params params; 916 - struct qedr_create_cq_ureq ureq = {}; 916 + struct qedr_create_cq_ureq ureq; 917 917 int vector = attr->comp_vector; 918 918 int entries = attr->cqe; 919 919 struct qedr_cq *cq = get_qedr_cq(ibcq); ··· 1541 1541 struct qedr_dev *dev = get_qedr_dev(ibsrq->device); 1542 1542 struct qed_rdma_create_srq_out_params out_params; 1543 1543 struct qedr_pd *pd = get_qedr_pd(ibsrq->pd); 1544 - struct qedr_create_srq_ureq ureq = {}; 1544 + struct qedr_create_srq_ureq ureq; 1545 1545 u64 pbl_base_addr, phy_prod_pair_addr; 1546 1546 struct qedr_srq_hwq_info *hw_srq; 1547 1547 u32 page_cnt, page_size; ··· 1837 1837 struct qed_rdma_create_qp_in_params in_params; 1838 1838 struct qed_rdma_create_qp_out_params out_params; 1839 1839 struct qedr_create_qp_uresp uresp = {}; 1840 - struct qedr_create_qp_ureq ureq = {}; 1840 + struct qedr_create_qp_ureq ureq; 1841 1841 int alloc_and_init = rdma_protocol_roce(&dev->ibdev, 1); 1842 1842 struct qedr_ucontext *ctx = NULL; 1843 1843 struct qedr_pd *pd = NULL;