Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

scsi: sd: Make sd shutdown issue START STOP UNIT appropriately

Commit aa3998dbeb3a ("ata: libata-scsi: Disable scsi device
manage_system_start_stop") enabled libata EH to manage device power mode
trasitions for system suspend/resume and removed the flag from
ata_scsi_dev_config. However, since the sd_shutdown() function still
relies on the manage_system_start_stop flag, a spin-down command is not
issued to the disk with command "echo 1 > /sys/block/sdb/device/delete"

sd_shutdown() can be called for both system/runtime start stop
operations, so utilize the manage_run_time_start_stop flag set in the
ata_scsi_dev_config and issue a spin-down command during disk removal
when the system is running. This is in addition to when the system is
powering off and manage_shutdown flag is set. The
manage_system_start_stop flag will still be used for drivers that still
set the flag.

Fixes: aa3998dbeb3a ("ata: libata-scsi: Disable scsi device manage_system_start_stop")
Signed-off-by: Salomon Dushimirimana <salomondush@google.com>
Link: https://lore.kernel.org/r/20250724214520.112927-1-salomondush@google.com
Tested-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Salomon Dushimirimana and committed by
Martin K. Petersen
8e48727c a28f9810

+3 -1
+3 -1
drivers/scsi/sd.c
··· 4168 4168 if ((system_state != SYSTEM_RESTART && 4169 4169 sdkp->device->manage_system_start_stop) || 4170 4170 (system_state == SYSTEM_POWER_OFF && 4171 - sdkp->device->manage_shutdown)) { 4171 + sdkp->device->manage_shutdown) || 4172 + (system_state == SYSTEM_RUNNING && 4173 + sdkp->device->manage_runtime_start_stop)) { 4172 4174 sd_printk(KERN_NOTICE, sdkp, "Stopping disk\n"); 4173 4175 sd_start_stop_device(sdkp, 0); 4174 4176 }