tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

usb: typec: cros-ec-ucsi: Add newlines to printk messages

These printks need newlines. Add them and convert to dev_err_probe() in
cros_ucsi_probe() to simplify code.

Cc: Pavan Holla <pholla@chromium.org>
Cc: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Cc: Łukasz Bartosik <ukaszb@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Łukasz Bartosik <ukaszb@chromium.org>
Link: https://lore.kernel.org/r/20250109220655.1677506-2-swboyd@chromium.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Stephen Boyd and committed by
Greg Kroah-Hartman 8ec7cac6 653e11ea

+12 -16
+12 -16
drivers/usb/typec/ucsi/cros_ec_ucsi.c
··· 58 58 int ret; 59 59 60 60 if (val_len > MAX_EC_DATA_SIZE) { 61 - dev_err(udata->dev, "Can't read %zu bytes. Too big.", val_len); 61 + dev_err(udata->dev, "Can't read %zu bytes. Too big.\n", val_len); 62 62 return -EINVAL; 63 63 } 64 64 65 65 ret = cros_ec_cmd(udata->ec, 0, EC_CMD_UCSI_PPM_GET, 66 66 &req, sizeof(req), val, val_len); 67 67 if (ret < 0) { 68 - dev_warn(udata->dev, "Failed to send EC message UCSI_PPM_GET: error=%d", ret); 68 + dev_warn(udata->dev, "Failed to send EC message UCSI_PPM_GET: error=%d\n", ret); 69 69 return ret; 70 70 } 71 71 return 0; ··· 99 99 ret = cros_ec_cmd(udata->ec, 0, EC_CMD_UCSI_PPM_SET, 100 100 req, sizeof(ec_buf), NULL, 0); 101 101 if (ret < 0) { 102 - dev_warn(udata->dev, "Failed to send EC message UCSI_PPM_SET: error=%d", ret); 102 + dev_warn(udata->dev, "Failed to send EC message UCSI_PPM_SET: error=%d\n", ret); 103 103 return ret; 104 104 } 105 105 return 0; ··· 161 161 162 162 if (cros_ucsi_read(udata->ucsi, UCSI_CCI, &cci, sizeof(cci))) { 163 163 dev_err(udata->dev, 164 - "Reading CCI failed; no write timeout recovery possible."); 164 + "Reading CCI failed; no write timeout recovery possible.\n"); 165 165 return; 166 166 } 167 167 ··· 173 173 msecs_to_jiffies(WRITE_TMO_MS)); 174 174 else 175 175 dev_err(udata->dev, 176 - "PPM unresponsive - too many write timeouts."); 176 + "PPM unresponsive - too many write timeouts.\n"); 177 177 178 178 return; 179 179 } ··· 208 208 if (!(host_event & PD_EVENT_PPM)) 209 209 return NOTIFY_OK; 210 210 211 - dev_dbg(udata->dev, "UCSI notification received"); 211 + dev_dbg(udata->dev, "UCSI notification received\n"); 212 212 flush_work(&udata->work); 213 213 schedule_work(&udata->work); 214 214 ··· 237 237 udata->dev = dev; 238 238 239 239 udata->ec = ec_data->ec_dev; 240 - if (!udata->ec) { 241 - dev_err(dev, "couldn't find parent EC device"); 242 - return -ENODEV; 243 - } 240 + if (!udata->ec) 241 + return dev_err_probe(dev, -ENODEV, "couldn't find parent EC device\n"); 244 242 245 243 platform_set_drvdata(pdev, udata); 246 244 ··· 247 249 init_completion(&udata->complete); 248 250 249 251 udata->ucsi = ucsi_create(dev, &cros_ucsi_ops); 250 - if (IS_ERR(udata->ucsi)) { 251 - dev_err(dev, "failed to allocate UCSI instance"); 252 - return PTR_ERR(udata->ucsi); 253 - } 252 + if (IS_ERR(udata->ucsi)) 253 + return dev_err_probe(dev, PTR_ERR(udata->ucsi), "failed to allocate UCSI instance\n"); 254 254 255 255 ucsi_set_drvdata(udata->ucsi, udata); 256 256 257 257 udata->nb.notifier_call = cros_ucsi_event; 258 258 ret = cros_usbpd_register_notify(&udata->nb); 259 259 if (ret) { 260 - dev_err(dev, "failed to register notifier: error=%d", ret); 260 + dev_err_probe(dev, ret, "failed to register notifier\n"); 261 261 ucsi_destroy(udata->ucsi); 262 262 return ret; 263 263 } 264 264 265 265 ret = ucsi_register(udata->ucsi); 266 266 if (ret) { 267 - dev_err(dev, "failed to register UCSI: error=%d", ret); 267 + dev_err_probe(dev, ret, "failed to register UCSI\n"); 268 268 cros_ucsi_destroy(udata); 269 269 return ret; 270 270 }