tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/solomon: Simplify get_modes() using DRM helper

The ssd130x_connector_get_modes function contains a manual implementation
to manage modes.

This pattern is common for simple displays, and the DRM core already
provides the drm_connector_helper_get_modes_fixed() helper for this exact
use case.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
Link: https://lore.kernel.org/r/20250920-improve-ssd130x-v2-4-77721e87ae08@gmail.com
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>

authored by

Iker Pedrosa and committed by
Javier Martinez Canillas 90905f37 7556fe21

+1 -13
+1 -13
drivers/gpu/drm/solomon/ssd130x.c
··· 1732 1732 static int ssd130x_connector_get_modes(struct drm_connector *connector) 1733 1733 { 1734 1734 struct ssd130x_device *ssd130x = drm_to_ssd130x(connector->dev); 1735 - struct drm_display_mode *mode; 1736 - struct device *dev = ssd130x->dev; 1737 1735 1738 - mode = drm_mode_duplicate(connector->dev, &ssd130x->mode); 1739 - if (!mode) { 1740 - dev_err(dev, "Failed to duplicated mode\n"); 1741 - return 0; 1742 - } 1743 - 1744 - drm_mode_probed_add(connector, mode); 1745 - drm_set_preferred_mode(connector, mode->hdisplay, mode->vdisplay); 1746 - 1747 - /* There is only a single mode */ 1748 - return 1; 1736 + return drm_connector_helper_get_modes_fixed(connector, &ssd130x->mode); 1749 1737 } 1750 1738 1751 1739 static const struct drm_connector_helper_funcs ssd130x_connector_helper_funcs = {