tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

sched/fair: Update overutilized detection

Checking uclamp_min is useless and counterproductive for overutilized state
as misfit can now happen without being in overutilized state.

Since commit e5ed0550c04c ("sched/fair: unlink misfit task from cpu overutilized")
util_fits_cpu returns -1 when uclamp_min is above capacity which is not
considered as cpu overutilized.

Remove the useless rq_util_min parameter.

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Qais Yousef <qyousef@layalina.io>
Reviewed-by: Christian Loehle <christian.loehle@arm.com>
Link: https://patch.msgid.link/20260213101751.3121899-1-vincent.guittot@linaro.org

authored by

Vincent Guittot and committed by
Peter Zijlstra 92647580 db4551e2

+2 -3
+2 -3
kernel/sched/fair.c
··· 7018 7018 7019 7019 static inline bool cpu_overutilized(int cpu) 7020 7020 { 7021 - unsigned long rq_util_min, rq_util_max; 7021 + unsigned long rq_util_max; 7022 7022 7023 7023 if (!sched_energy_enabled()) 7024 7024 return false; 7025 7025 7026 - rq_util_min = uclamp_rq_get(cpu_rq(cpu), UCLAMP_MIN); 7027 7026 rq_util_max = uclamp_rq_get(cpu_rq(cpu), UCLAMP_MAX); 7028 7027 7029 7028 /* Return true only if the utilization doesn't fit CPU's capacity */ 7030 - return !util_fits_cpu(cpu_util_cfs(cpu), rq_util_min, rq_util_max, cpu); 7029 + return !util_fits_cpu(cpu_util_cfs(cpu), 0, rq_util_max, cpu); 7031 7030 } 7032 7031 7033 7032 /*