tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Revert "io_uring/rw: drop -EOPNOTSUPP check in __io_complete_rw_common()"

This reverts commit 90bfb28d5fa8127a113a140c9791ea0b40ab156a.

Kevin reports that this commit causes an issue for him with LVM
snapshots, most likely because of turning off NOWAIT support while a
snapshot is being created. This makes -EOPNOTSUPP bubble back through
the completion handler, where io_uring read/write handling should just
retry it.

Reinstate the previous check removed by the referenced commit.

Cc: stable@vger.kernel.org
Fixes: 90bfb28d5fa8 ("io_uring/rw: drop -EOPNOTSUPP check in __io_complete_rw_common()")
Reported-by: Salvatore Bonaccorso <carnil@debian.org>
Reported-by: Kevin Lumik <kevin@xf.ee>
Link: https://lore.kernel.org/io-uring/cceb723c-051b-4de2-9a4c-4aa82e1619ee@kernel.dk/
Signed-off-by: Jens Axboe <axboe@kernel.dk>

Jens Axboe 927069c4 3a866087

+1 -1
+1 -1
io_uring/rw.c
··· 542 542 { 543 543 if (res == req->cqe.res) 544 544 return; 545 - if (res == -EAGAIN && io_rw_should_reissue(req)) { 545 + if ((res == -EOPNOTSUPP || res == -EAGAIN) && io_rw_should_reissue(req)) { 546 546 req->flags |= REQ_F_REISSUE | REQ_F_BL_NO_RECYCLE; 547 547 } else { 548 548 req_set_fail(req);