tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

can: netlink: document which symbols are FD specific

The CAN XL netlink interface will also have data bitrate and TDC
parameters. The current FD parameters do not have a prefix in their
names to differentiate them.

Because the netlink interface is part of the UAPI, it is unfortunately
not feasible to rename the existing symbols to add an FD_ prefix. The
best alternative is to add a comment for each of the symbols to notify
the reader of which parts are CAN FD specific.

While at it, fix a typo: transiver -> transceiver.

Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
Link: https://patch.msgid.link/20250923-canxl-netlink-prep-v4-3-e720d28f66fe@kernel.org
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

authored by

Vincent Mailhol and committed by
Marc Kleine-Budde 94040a8f 7208385d

+7 -7
+7 -7
include/uapi/linux/can/netlink.h
··· 101 101 #define CAN_CTRLMODE_PRESUME_ACK 0x40 /* Ignore missing CAN ACKs */ 102 102 #define CAN_CTRLMODE_FD_NON_ISO 0x80 /* CAN FD in non-ISO mode */ 103 103 #define CAN_CTRLMODE_CC_LEN8_DLC 0x100 /* Classic CAN DLC option */ 104 - #define CAN_CTRLMODE_TDC_AUTO 0x200 /* CAN transiver automatically calculates TDCV */ 105 - #define CAN_CTRLMODE_TDC_MANUAL 0x400 /* TDCV is manually set up by user */ 104 + #define CAN_CTRLMODE_TDC_AUTO 0x200 /* FD transceiver automatically calculates TDCV */ 105 + #define CAN_CTRLMODE_TDC_MANUAL 0x400 /* FD TDCV is manually set up by user */ 106 106 107 107 /* 108 108 * CAN device statistics ··· 129 129 IFLA_CAN_RESTART_MS, 130 130 IFLA_CAN_RESTART, 131 131 IFLA_CAN_BERR_COUNTER, 132 - IFLA_CAN_DATA_BITTIMING, 133 - IFLA_CAN_DATA_BITTIMING_CONST, 132 + IFLA_CAN_DATA_BITTIMING, /* FD */ 133 + IFLA_CAN_DATA_BITTIMING_CONST, /* FD */ 134 134 IFLA_CAN_TERMINATION, 135 135 IFLA_CAN_TERMINATION_CONST, 136 136 IFLA_CAN_BITRATE_CONST, 137 - IFLA_CAN_DATA_BITRATE_CONST, 137 + IFLA_CAN_DATA_BITRATE_CONST, /* FD */ 138 138 IFLA_CAN_BITRATE_MAX, 139 - IFLA_CAN_TDC, 139 + IFLA_CAN_TDC, /* FD */ 140 140 IFLA_CAN_CTRLMODE_EXT, 141 141 142 142 /* add new constants above here */ ··· 145 145 }; 146 146 147 147 /* 148 - * CAN FD Transmitter Delay Compensation (TDC) 148 + * CAN FD/XL Transmitter Delay Compensation (TDC) 149 149 * 150 150 * Please refer to struct can_tdc_const and can_tdc in 151 151 * include/linux/can/bittiming.h for further details.