tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

sfc: fix deadlock in RSS config read

Since cited commit, core locks the net_device's rss_lock when handling
ethtool -x command, so driver's implementation should not lock it
again. Remove the latter.

Fixes: 040cef30b5e6 ("net: ethtool: move get_rxfh callback under the rss_lock")
Reported-by: Damir Mansurov <damir.mansurov@oktetlabs.ru>
Closes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1126015
Suggested-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Link: https://patch.msgid.link/20260123161634.1215006-1-edward.cree@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Edward Cree and committed by
Jakub Kicinski 944c614b f66f5c21

+1 -6
+1 -6
drivers/net/ethernet/sfc/mcdi_filters.c
··· 2182 2182 2183 2183 int efx_mcdi_rx_pull_rss_config(struct efx_nic *efx) 2184 2184 { 2185 - int rc; 2186 - 2187 - mutex_lock(&efx->net_dev->ethtool->rss_lock); 2188 - rc = efx_mcdi_rx_pull_rss_context_config(efx, &efx->rss_context); 2189 - mutex_unlock(&efx->net_dev->ethtool->rss_lock); 2190 - return rc; 2185 + return efx_mcdi_rx_pull_rss_context_config(efx, &efx->rss_context); 2191 2186 } 2192 2187 2193 2188 void efx_mcdi_rx_restore_rss_contexts(struct efx_nic *efx)