tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

[PATCH] clocksource: Fix thinko in watchdog selection

The watchdog implementation excludes low res / non continuous
clocksources from being selected as a watchdog reference
unintentionally.

Allow using jiffies/PIT as a watchdog reference as long as no better
clocksource is available. This is necessary to detect TSC breakage on
systems, which have no pmtimer/hpet.

The main goal of the initial patch (preventing to switch to highres/nohz
when no reliable fallback clocksource is available) is still guaranteed
by the checks in clocksource_watchdog().

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Thomas Gleixner and committed by
Linus Torvalds 948ac6d7 9501b6cf

+2 -1
+2 -1
kernel/time/clocksource.c
··· 151 151 watchdog_timer.expires = jiffies + WATCHDOG_INTERVAL; 152 152 add_timer(&watchdog_timer); 153 153 } 154 - } else if (cs->flags & CLOCK_SOURCE_IS_CONTINUOUS) { 154 + } else { 155 + if (cs->flags & CLOCK_SOURCE_IS_CONTINUOUS) 155 156 cs->flags |= CLOCK_SOURCE_VALID_FOR_HRES; 156 157 157 158 if (!watchdog || cs->rating > watchdog->rating) {