Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
gpu: nova-core: gsp: remove unneeded sequencer trait
The `GspSeqCmdRunner` trait is never used as we never call the `run`
methods from generic code. Remove it.
Reviewed-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Gary Guo <gary@garyguo.net>
Reviewed-by: Danilo Krummrich <dakr@kernel.org>
Link: https://patch.msgid.link/20260217-nova-misc-v3-4-b4e2d45eafbc@nvidia.com
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
+6
-11
+6
-11
drivers/gpu/nova-core/gsp/sequencer.rs
+6
-11
drivers/gpu/nova-core/gsp/sequencer.rs
···
144
144
dev: ARef<device::Device>,
145
145
}
146
146
147
-
/// Trait for running sequencer commands.
148
-
pub(crate) trait GspSeqCmdRunner {
149
-
fn run(&self, sequencer: &GspSequencer<'_>) -> Result;
150
-
}
151
-
152
-
impl GspSeqCmdRunner for fw::RegWritePayload {
147
+
impl fw::RegWritePayload {
153
148
fn run(&self, sequencer: &GspSequencer<'_>) -> Result {
154
149
let addr = usize::from_safe_cast(self.addr());
155
150
···
152
157
}
153
158
}
154
159
155
-
impl GspSeqCmdRunner for fw::RegModifyPayload {
160
+
impl fw::RegModifyPayload {
156
161
fn run(&self, sequencer: &GspSequencer<'_>) -> Result {
157
162
let addr = usize::from_safe_cast(self.addr());
158
163
···
164
169
}
165
170
}
166
171
167
-
impl GspSeqCmdRunner for fw::RegPollPayload {
172
+
impl fw::RegPollPayload {
168
173
fn run(&self, sequencer: &GspSequencer<'_>) -> Result {
169
174
let addr = usize::from_safe_cast(self.addr());
170
175
···
189
194
}
190
195
}
191
196
192
-
impl GspSeqCmdRunner for fw::DelayUsPayload {
197
+
impl fw::DelayUsPayload {
193
198
fn run(&self, _sequencer: &GspSequencer<'_>) -> Result {
194
199
fsleep(Delta::from_micros(i64::from(self.val())));
195
200
Ok(())
196
201
}
197
202
}
198
203
199
-
impl GspSeqCmdRunner for fw::RegStorePayload {
204
+
impl fw::RegStorePayload {
200
205
fn run(&self, sequencer: &GspSequencer<'_>) -> Result {
201
206
let addr = usize::from_safe_cast(self.addr());
202
207
···
204
209
}
205
210
}
206
211
207
-
impl GspSeqCmdRunner for GspSeqCmd {
212
+
impl GspSeqCmd {
208
213
fn run(&self, seq: &GspSequencer<'_>) -> Result {
209
214
match self {
210
215
GspSeqCmd::RegWrite(cmd) => cmd.run(seq),