tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

KVM: SVM: Drop the module param to control SEV-ES DebugSwap

Rip out the DebugSwap module param, as the sequence of events that led to
its inclusion was one big mistake, the param no longer serves any purpose.

Commit d1f85fbe836e ("KVM: SEV: Enable data breakpoints in SEV-ES") goofed
by not adding a way for the userspace VMM to control the feature.
Functionally, that was fine, but it broke attestation signatures because
SEV_FEATURES are included in the signature.

Commit 5abf6dceb066 ("SEV: disable SEV-ES DebugSwap by default") fixed that
issue, but the underlying flaw of userspace not having a way to control
SEV_FEATURES was still there.

That flaw was addressed by commit 4f5defae7089 ("KVM: SEV: introduce
KVM_SEV_INIT2 operation"), and so then 4dd5ecacb9a4 ("KVM: SEV: allow
SEV-ES DebugSwap again") re-enabled DebugSwap by default.

Now that the dust has settled, the module param doesn't serve any
meaningful purpose.

Cc: Tom Lendacky <thomas.lendacky@amd.com>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
Link: https://patch.msgid.link/20260109033101.1005769-2-seanjc@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>

Sean Christopherson 9587dd7a ca2eccb9

+3 -8
+3 -8
arch/x86/kvm/svm/sev.c
··· 53 53 static bool sev_snp_enabled = true; 54 54 module_param_named(sev_snp, sev_snp_enabled, bool, 0444); 55 55 56 - /* enable/disable SEV-ES DebugSwap support */ 57 - static bool sev_es_debug_swap_enabled = true; 58 - module_param_named(debug_swap, sev_es_debug_swap_enabled, bool, 0444); 59 56 static u64 sev_supported_vmsa_features; 60 57 61 58 static unsigned int nr_ciphertext_hiding_asids; ··· 3147 3150 sev_es_enabled = sev_es_supported; 3148 3151 sev_snp_enabled = sev_snp_supported; 3149 3152 3150 - if (!sev_es_enabled || !cpu_feature_enabled(X86_FEATURE_DEBUG_SWAP) || 3151 - !cpu_feature_enabled(X86_FEATURE_NO_NESTED_DATA_BP)) 3152 - sev_es_debug_swap_enabled = false; 3153 - 3154 3153 sev_supported_vmsa_features = 0; 3155 - if (sev_es_debug_swap_enabled) 3154 + 3155 + if (sev_es_enabled && cpu_feature_enabled(X86_FEATURE_DEBUG_SWAP) && 3156 + cpu_feature_enabled(X86_FEATURE_NO_NESTED_DATA_BP)) 3156 3157 sev_supported_vmsa_features |= SVM_SEV_FEAT_DEBUG_SWAP; 3157 3158 3158 3159 if (sev_snp_enabled && tsc_khz && cpu_feature_enabled(X86_FEATURE_SNP_SECURE_TSC))