tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/i915/dp: Simplify forcing a link retraining

Since both the DP SST and MST HPD IRQ handlers call
intel_dp_handle_link_service_irq() with LINK_STATUS_CHANGED set in
irq_mask if intel_dp->link.force_retrain is set, checking for the former
flag is sufficient to determine if the link status needs to be checked
(which includes retraining the link if this is forced); remove checking
for the latter flag.

Since LINK_STATUS_CHANGED is currently set unconditionally for DP SST,
extend the related comment to note that it must be set if
intel_dp->link.force_retrain is set (in case setting LINK_STATUS_CHANGED
becomes conditional on DPCD_REV).

Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://patch.msgid.link/20260311153152.133744-2-imre.deak@intel.com

Imre Deak 95acbb07 e41e992c

+2 -2
+2 -2
drivers/gpu/drm/i915/display/intel_dp.c
··· 5925 5925 if (irq_mask & RX_CAP_CHANGED) 5926 5926 reprobe_needed = true; 5927 5927 5928 - if ((irq_mask & LINK_STATUS_CHANGED) || intel_dp->link.force_retrain) 5928 + if (irq_mask & LINK_STATUS_CHANGED) 5929 5929 intel_dp_check_link_state(intel_dp); 5930 5930 5931 5931 if (irq_mask & HDMI_LINK_STATUS_CHANGED) ··· 5984 5984 /* 5985 5985 * Force checking the link status for DPCD_REV < 1.2 5986 5986 * TODO: let the link status check depend on LINK_STATUS_CHANGED 5987 - * for DPCD_REV >= 1.2 5987 + * or intel_dp->link.force_retrain for DPCD_REV >= 1.2 5988 5988 */ 5989 5989 esi[3] |= LINK_STATUS_CHANGED; 5990 5990 if (intel_dp_handle_link_service_irq(intel_dp, esi[3]))