tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

bpf: Clarify get_outer_instance() handling in propagate_to_outer_instance()

propagate_to_outer_instance() calls get_outer_instance() and uses the
returned pointer to reset and commit stack write marks. Under normal
conditions, update_instance() guarantees that an outer instance exists,
so get_outer_instance() cannot return an ERR_PTR.

However, explicitly checking for IS_ERR(outer_instance) makes this code
more robust and self-documenting. It reduces cognitive load when reading
the control flow and silences potential false-positive reports from
static analysis or automated tooling.

No functional change intended.

Signed-off-by: Shardul Bankar <shardulsb08@gmail.com>
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Link: https://lore.kernel.org/r/20251021080849.860072-1-shardulsb08@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>

authored by

Shardul Bankar and committed by
Alexei Starovoitov 96d31dff 04a89957

+2
+2
kernel/bpf/liveness.c
··· 524 524 525 525 this_subprog_start = callchain_subprog_start(callchain); 526 526 outer_instance = get_outer_instance(env, instance); 527 + if (IS_ERR(outer_instance)) 528 + return PTR_ERR(outer_instance); 527 529 callsite = callchain->callsites[callchain->curframe - 1]; 528 530 529 531 reset_stack_write_marks(env, outer_instance, callsite);