tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

perf build: fix "argument list too long" in second location

Turns out that displaying "RM $^" via quiet_cmd_rm can also upset the
shell and cause it to display "argument list too long".

Trying to quote $^ doesn't help.

In the end, *not* displaying the (potentially long) list of files is
probably the right thing to do for a "quiet" message, anyway. Instead,
let's display a count of how many files were removed. There is always
V=1 if more detail is required.

TEST linux/tools/perf/pmu-events/metric_test.log
RM ...634 orphan file(s)...
LD linux/tools/perf/util/perf-util-in.o

Also move the comment regarding xargs before the rule, so it doesn't
show up in the build output.

Signed-off-by: Markus Mayer <mmayer@broadcom.com>
Reviewed-by: James Clark <james.clark@linaro.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>

authored by

Markus Mayer and committed by
Namhyung Kim 97ab8968 dff56bda

+2 -2
+2 -2
tools/perf/pmu-events/Build
··· 211 211 212 212 # Message for $(call echo-cmd,rm). Generally cleaning files isn't part 213 213 # of a build step. 214 - quiet_cmd_rm = RM $^ 214 + quiet_cmd_rm = RM ...$(words $^) orphan file(s)... 215 215 216 + # The list of files can be long. Use xargs to prevent issues. 216 217 prune_orphans: $(ORPHAN_FILES) 217 - # The list of files can be long. Use xargs to prevent issues. 218 218 $(Q)$(call echo-cmd,rm)echo "$^" | xargs rm -f 219 219 220 220 JEVENTS_DEPS += prune_orphans