Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/memcg: use kmem_cache when alloc memcg

When tracing mem_cgroup_alloc() with kmalloc ftrace, we observe:

kmalloc: call_site=mem_cgroup_css_alloc+0xd8/0x5b4 ptr=000000003e4c3799
bytes_req=2312 bytes_alloc=4096 gfp_flags=GFP_KERNEL|__GFP_ZERO node=-1
accounted=false

The output indicates that while allocating mem_cgroup struct (2312 bytes),
the slab allocator actually provides 4096-byte chunks. This occurs because:

1. The slab allocator predefines bucket sizes from 64B to 8096B
2. The mem_cgroup allocation size (2312B) falls between the 2KB and 4KB
slabs
3. The allocator rounds up to the nearest larger slab (4KB), resulting in
~1KB wasted memory per allocation

This patch introduces a dedicated kmem_cache for mem_cgroup structs,
achieving precise memory allocation. Post-patch ftrace verification shows:

kmem_cache_alloc: call_site=mem_cgroup_css_alloc+0xbc/0x5d4
ptr=00000000695c1806 bytes_req=2312 bytes_alloc=2368
gfp_flags=GFP_KERNEL|__GFP_ZERO node=-1 accounted=false

Each memcg alloc offer 2368bytes(include hw cacheline align), compare to
4096, avoid waste.

Link: https://lkml.kernel.org/r/20250425031935.76411-3-link@vivo.com
Signed-off-by: Huan Yang <link@vivo.com>
Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Francesco Valla <francesco@valla.it>
Cc: guoweikang <guoweikang.kernel@gmail.com>
Cc: Huang Shijie <shijie@os.amperecomputing.com>
Cc: KP Singh <kpsingh@kernel.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Muchun Song <muchun.song@linux.dev>
Cc: "Paul E . McKenney" <paulmck@kernel.org>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Raul E Rangel <rrangel@chromium.org>
Cc: Roman Gushchin <roman.gushchin@linux.dev>
Cc: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Huan Yang and committed by
Andrew Morton
97e4fc4b bc9817bb

+8 -1
+8 -1
mm/memcontrol.c
··· 96 96 /* BPF memory accounting disabled? */ 97 97 static bool cgroup_memory_nobpf __ro_after_init; 98 98 99 + static struct kmem_cache *memcg_cachep; 100 + 99 101 #ifdef CONFIG_CGROUP_WRITEBACK 100 102 static DECLARE_WAIT_QUEUE_HEAD(memcg_cgwb_frn_waitq); 101 103 #endif ··· 3667 3665 int __maybe_unused i; 3668 3666 long error; 3669 3667 3670 - memcg = kzalloc(struct_size(memcg, nodeinfo, nr_node_ids), GFP_KERNEL); 3668 + memcg = kmem_cache_zalloc(memcg_cachep, GFP_KERNEL); 3671 3669 if (!memcg) 3672 3670 return ERR_PTR(-ENOMEM); 3673 3671 ··· 5053 5051 */ 5054 5052 int __init mem_cgroup_init(void) 5055 5053 { 5054 + unsigned int memcg_size; 5056 5055 int cpu; 5057 5056 5058 5057 /* ··· 5070 5067 for_each_possible_cpu(cpu) 5071 5068 INIT_WORK(&per_cpu_ptr(&memcg_stock, cpu)->work, 5072 5069 drain_local_stock); 5070 + 5071 + memcg_size = struct_size_t(struct mem_cgroup, nodeinfo, nr_node_ids); 5072 + memcg_cachep = kmem_cache_create("mem_cgroup", memcg_size, 0, 5073 + SLAB_PANIC | SLAB_HWCACHE_ALIGN, NULL); 5073 5074 5074 5075 return 0; 5075 5076 }