tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Input: drv260x - remove unused .reg_defaults

Since the driver has disabled regmap caching with REGCACHE_NONE, it's
warning us that we provide defaults that are not used. Remove them.

[ 0.561159] drv260x-haptics 0-005a: No cache used with register defaults set!

Fixes: 7132fe4f5687 ("Input: drv260x - add TI drv260x haptics driver")
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
Link: https://lore.kernel.org/r/20230430-drv260x-improvements-v1-3-1fb28b4cc698@z3ntu.xyz
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Luca Weiss and committed by
Dmitry Torokhov 980626ec efef661d

-40
-40
drivers/input/misc/drv260x.c
··· 193 193 int overdrive_voltage; 194 194 }; 195 195 196 - static const struct reg_default drv260x_reg_defs[] = { 197 - { DRV260X_STATUS, 0xe0 }, 198 - { DRV260X_MODE, 0x40 }, 199 - { DRV260X_RT_PB_IN, 0x00 }, 200 - { DRV260X_LIB_SEL, 0x00 }, 201 - { DRV260X_WV_SEQ_1, 0x01 }, 202 - { DRV260X_WV_SEQ_2, 0x00 }, 203 - { DRV260X_WV_SEQ_3, 0x00 }, 204 - { DRV260X_WV_SEQ_4, 0x00 }, 205 - { DRV260X_WV_SEQ_5, 0x00 }, 206 - { DRV260X_WV_SEQ_6, 0x00 }, 207 - { DRV260X_WV_SEQ_7, 0x00 }, 208 - { DRV260X_WV_SEQ_8, 0x00 }, 209 - { DRV260X_GO, 0x00 }, 210 - { DRV260X_OVERDRIVE_OFF, 0x00 }, 211 - { DRV260X_SUSTAIN_P_OFF, 0x00 }, 212 - { DRV260X_SUSTAIN_N_OFF, 0x00 }, 213 - { DRV260X_BRAKE_OFF, 0x00 }, 214 - { DRV260X_A_TO_V_CTRL, 0x05 }, 215 - { DRV260X_A_TO_V_MIN_INPUT, 0x19 }, 216 - { DRV260X_A_TO_V_MAX_INPUT, 0xff }, 217 - { DRV260X_A_TO_V_MIN_OUT, 0x19 }, 218 - { DRV260X_A_TO_V_MAX_OUT, 0xff }, 219 - { DRV260X_RATED_VOLT, 0x3e }, 220 - { DRV260X_OD_CLAMP_VOLT, 0x8c }, 221 - { DRV260X_CAL_COMP, 0x0c }, 222 - { DRV260X_CAL_BACK_EMF, 0x6c }, 223 - { DRV260X_FEEDBACK_CTRL, 0x36 }, 224 - { DRV260X_CTRL1, 0x93 }, 225 - { DRV260X_CTRL2, 0xfa }, 226 - { DRV260X_CTRL3, 0xa0 }, 227 - { DRV260X_CTRL4, 0x20 }, 228 - { DRV260X_CTRL5, 0x80 }, 229 - { DRV260X_LRA_LOOP_PERIOD, 0x33 }, 230 - { DRV260X_VBAT_MON, 0x00 }, 231 - { DRV260X_LRA_RES_PERIOD, 0x00 }, 232 - }; 233 - 234 196 #define DRV260X_DEF_RATED_VOLT 0x90 235 197 #define DRV260X_DEF_OD_CLAMP_VOLT 0x90 236 198 ··· 415 453 .val_bits = 8, 416 454 417 455 .max_register = DRV260X_MAX_REG, 418 - .reg_defaults = drv260x_reg_defs, 419 - .num_reg_defaults = ARRAY_SIZE(drv260x_reg_defs), 420 456 .cache_type = REGCACHE_NONE, 421 457 }; 422 458