tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ASoC: codecs: aw88395: initialize cur_scene_id to 0

cppcheck reports
sound/soc/codecs/aw88395/aw88395_lib.c:789:6: error: Uninitialized variable: cur_scene_id [uninitvar]
if (cur_scene_id == 0) {
^

Passing a garbage value to aw_dev_parse_data_by_sec_type_v1() will cause a crash
when the value is used as an array index. This check assumes cur_scene_id is
initialized to 0, so initialize it to 0.

Fixes: 4345865b003b ("ASoC: codecs: ACF bin parsing and check library file for aw88395")
Signed-off-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20230205015733.1721009-1-trix@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Tom Rix and committed by
Mark Brown 983272a2 700ed3bb

+1 -1
+1 -1
sound/soc/codecs/aw88395/aw88395_lib.c
··· 769 769 { 770 770 struct aw_cfg_dde_v1 *cfg_dde = 771 771 (struct aw_cfg_dde_v1 *)((char *)prof_hdr + prof_hdr->hdr_offset); 772 - int cur_scene_id; 772 + int cur_scene_id = 0; 773 773 unsigned int i; 774 774 int ret; 775 775