Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

eth: fbnic: fix memory corruption in fbnic_tlv_attr_get_string()

This code is trying to ensure that the last byte of the buffer is a NUL
terminator. However, the problem is that attr->value[] is an array of
__le32, not char, so it zeroes out 4 bytes way beyond the end of the
buffer. Cast the buffer to char to address this.

Fixes: e5cf5107c9e4 ("eth: fbnic: Update fbnic_tlv_attr_get_string() to work like nla_strscpy()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Lee Trager <lee@trager.us>
Link: https://patch.msgid.link/2791d4be-ade4-4e50-9b12-33307d8410f6@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Dan Carpenter and committed by
Jakub Kicinski
991a1b09 473367a5

+1 -1
+1 -1
drivers/net/ethernet/meta/fbnic/fbnic_tlv.c
··· 261 261 return -E2BIG; 262 262 263 263 srclen = le16_to_cpu(attr->hdr.len) - sizeof(*attr); 264 - if (srclen > 0 && attr->value[srclen - 1] == '\0') 264 + if (srclen > 0 && ((char *)attr->value)[srclen - 1] == '\0') 265 265 srclen--; 266 266 267 267 if (srclen >= dstsize) {