tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

usb: xhci: simplify Max Scratchpad buffer macros

Max Scratchpad Buffers consist of two bit-fields:
bits 25:21 - Max Scratchpad Buffers High, 5 Most significant bits
bits 27:31 - Max Scratchpad Buffers Low, 5 Least significant bits
Combined they create the Max Scratchpad Buffers value.

Add two new macros, 'HCS_MAX_SP_HI' and 'HCS_MAX_SP_LO', to separately
extract the high and low parts of the Max Scratchpad Buffers. These are
then combined using 'HCS_MAX_SCRATCHPAD' macro. This change simplifies
the code and makes it similar to other split value register macros in the
xhci driver.

Signed-off-by: Niklas Neronin <niklas.neronin@linux.intel.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://patch.msgid.link/20251119142417.2820519-21-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Niklas Neronin and committed by
Greg Kroah-Hartman 99369090 f724e347

+3 -1
+3 -1
drivers/usb/host/xhci-caps.h
··· 37 37 #define HCS_ERST_MAX(p) (((p) >> 4) & 0xf) 38 38 /* bits 20:8 - Rsvd */ 39 39 /* bits 25:21 - Max Scratchpad Buffers (Hi), 5 Most significant bits */ 40 + #define HCS_MAX_SP_HI(p) (((p) >> 21) & 0x1f) 40 41 /* bit 26 - Scratchpad restore, for save/restore HW state */ 41 42 /* bits 31:27 - Max Scratchpad Buffers (Lo), 5 Least significant bits */ 42 - #define HCS_MAX_SCRATCHPAD(p) ((((p) >> 16) & 0x3e0) | (((p) >> 27) & 0x1f)) 43 + #define HCS_MAX_SP_LO(p) (((p) >> 27) & 0x1f) 44 + #define HCS_MAX_SCRATCHPAD(p) (HCS_MAX_SP_HI(p) << 5 | HCS_MAX_SP_LO(p)) 43 45 44 46 /* HCSPARAMS3 - hcs_params3 - bitmasks */ 45 47 /* bits 7:0 - U1 Device Exit Latency, Max U1 to U0 latency for the roothub ports */