Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
selftests/coredump: fix build
Fix various warnings in the selftest build.
Link: https://lore.kernel.org/20250603-work-coredump-socket-protocol-v2-2-05a5f0c18ecc@kernel.org
Acked-by: Lennart Poettering <lennart@poettering.net>
Reviewed-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
+6
-13
+1
-1
tools/testing/selftests/coredump/Makefile
+1
-1
tools/testing/selftests/coredump/Makefile
+5
-12
tools/testing/selftests/coredump/stackdump_test.c
+5
-12
tools/testing/selftests/coredump/stackdump_test.c
···
24
24
{
25
25
while (1)
26
26
pause();
27
+
28
+
return NULL;
27
29
}
28
30
29
31
static void crashing_child(void)
···
48
46
49
47
FIXTURE_SETUP(coredump)
50
48
{
51
-
char buf[PATH_MAX];
52
49
FILE *file;
53
-
char *dir;
54
50
int ret;
55
51
56
52
self->pid_coredump_server = -ESRCH;
···
106
106
107
107
TEST_F_TIMEOUT(coredump, stackdump, 120)
108
108
{
109
-
struct sigaction action = {};
110
109
unsigned long long stack;
111
110
char *test_dir, *line;
112
111
size_t line_length;
···
170
171
171
172
TEST_F(coredump, socket)
172
173
{
173
-
int fd, pidfd, ret, status;
174
+
int pidfd, ret, status;
174
175
FILE *file;
175
176
pid_t pid, pid_coredump_server;
176
177
struct stat st;
177
-
char core_file[PATH_MAX];
178
178
struct pidfd_info info = {};
179
179
int ipc_sockets[2];
180
180
char c;
···
354
356
355
357
TEST_F(coredump, socket_detect_userspace_client)
356
358
{
357
-
int fd, pidfd, ret, status;
359
+
int pidfd, ret, status;
358
360
FILE *file;
359
361
pid_t pid, pid_coredump_server;
360
362
struct stat st;
361
-
char core_file[PATH_MAX];
362
363
struct pidfd_info info = {};
363
364
int ipc_sockets[2];
364
365
char c;
···
381
384
pid_coredump_server = fork();
382
385
ASSERT_GE(pid_coredump_server, 0);
383
386
if (pid_coredump_server == 0) {
384
-
int fd_server, fd_coredump, fd_peer_pidfd, fd_core_file;
387
+
int fd_server, fd_coredump, fd_peer_pidfd;
385
388
socklen_t fd_peer_pidfd_len;
386
389
387
390
close(ipc_sockets[0]);
···
461
464
close(fd_coredump);
462
465
close(fd_server);
463
466
close(fd_peer_pidfd);
464
-
close(fd_core_file);
465
467
_exit(EXIT_SUCCESS);
466
468
}
467
469
self->pid_coredump_server = pid_coredump_server;
···
484
488
if (ret < 0)
485
489
_exit(EXIT_FAILURE);
486
490
487
-
(void *)write(fd_socket, &(char){ 0 }, 1);
488
491
close(fd_socket);
489
492
_exit(EXIT_SUCCESS);
490
493
}
···
514
519
int pidfd, ret, status;
515
520
FILE *file;
516
521
pid_t pid;
517
-
char core_file[PATH_MAX];
518
522
519
523
file = fopen("/proc/sys/kernel/core_pattern", "w");
520
524
ASSERT_NE(file, NULL);
···
563
569
ASSERT_GE(pid_coredump_server, 0);
564
570
if (pid_coredump_server == 0) {
565
571
int fd_server;
566
-
socklen_t fd_peer_pidfd_len;
567
572
568
573
close(ipc_sockets[0]);
569
574