Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: ch9200: fix uninitialised access during mii_nway_restart

In mii_nway_restart() the code attempts to call
mii->mdio_read which is ch9200_mdio_read(). ch9200_mdio_read()
utilises a local buffer called "buff", which is initialised
with control_read(). However "buff" is conditionally
initialised inside control_read():

if (err == size) {
memcpy(data, buf, size);
}

If the condition of "err == size" is not met, then
"buff" remains uninitialised. Once this happens the
uninitialised "buff" is accessed and returned during
ch9200_mdio_read():

return (buff[0] | buff[1] << 8);

The problem stems from the fact that ch9200_mdio_read()
ignores the return value of control_read(), leading to
uinit-access of "buff".

To fix this we should check the return value of
control_read() and return early on error.

Reported-by: syzbot <syzbot+3361c2d6f78a3e0892f9@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=3361c2d6f78a3e0892f9
Tested-by: syzbot <syzbot+3361c2d6f78a3e0892f9@syzkaller.appspotmail.com>
Fixes: 4a476bd6d1d9 ("usbnet: New driver for QinHeng CH9200 devices")
Cc: stable@vger.kernel.org
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
Link: https://patch.msgid.link/20250526183607.66527-1-qasdev00@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Qasim Ijaz and committed by
Jakub Kicinski
9ad0452c 8542d6fa

+5 -2
+5 -2
drivers/net/usb/ch9200.c
··· 178 178 { 179 179 struct usbnet *dev = netdev_priv(netdev); 180 180 unsigned char buff[2]; 181 + int ret; 181 182 182 183 netdev_dbg(netdev, "%s phy_id:%02x loc:%02x\n", 183 184 __func__, phy_id, loc); ··· 186 185 if (phy_id != 0) 187 186 return -ENODEV; 188 187 189 - control_read(dev, REQUEST_READ, 0, loc * 2, buff, 0x02, 190 - CONTROL_TIMEOUT_MS); 188 + ret = control_read(dev, REQUEST_READ, 0, loc * 2, buff, 0x02, 189 + CONTROL_TIMEOUT_MS); 190 + if (ret < 0) 191 + return ret; 191 192 192 193 return (buff[0] | buff[1] << 8); 193 194 }