Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/fb-helper: Remove test for fb_dirty callback from deferred-I/O helper
The helper for processing deferred I/O on pages has no dependency on
the fb_dirty damge-handling callback; so remove the test. In practice,
deferred I/O is only used with damage handling and the damage worker
already guarantees the presence of the fb_dirty callback.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20221115115819.23088-4-tzimmermann@suse.de
+7
-9
+7
-9
drivers/gpu/drm/drm_fb_helper.c
+7
-9
drivers/gpu/drm/drm_fb_helper.c
···
656
656
min_off = min(min_off, start);
657
657
max_off = max(max_off, end);
658
658
}
659
-
if (min_off >= max_off)
660
-
return;
661
659
662
-
if (helper->funcs->fb_dirty) {
663
-
/*
664
-
* As we can only track pages, we might reach beyond the end
665
-
* of the screen and account for non-existing scanlines. Hence,
666
-
* keep the covered memory area within the screen buffer.
667
-
*/
668
-
max_off = min(max_off, info->screen_size);
660
+
/*
661
+
* As we can only track pages, we might reach beyond the end
662
+
* of the screen and account for non-existing scanlines. Hence,
663
+
* keep the covered memory area within the screen buffer.
664
+
*/
665
+
max_off = min(max_off, info->screen_size);
669
666
667
+
if (min_off < max_off) {
670
668
drm_fb_helper_memory_range_to_clip(info, min_off, max_off - min_off, &damage_area);
671
669
drm_fb_helper_damage(helper, damage_area.x1, damage_area.y1,
672
670
drm_rect_width(&damage_area),