tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

fbdev: savage: fix probe-path EDID cleanup leaks

When CONFIG_FB_SAVAGE_I2C is enabled, savagefb_probe() can build both an
EDID-derived monspecs.modedb and a modelist from it before later failing.

The normal success path frees monspecs.modedb after the initial mode selection,
but the probe error path only deletes the I2C busses and misses the
EDID-derived allocations.

Free both the modelist and monspecs.modedb on the failed: unwind path.

Co-developed-by: Myeonghun Pak <mhun512@gmail.com>
Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
Co-developed-by: Ijae Kim <ae878000@gmail.com>
Signed-off-by: Ijae Kim <ae878000@gmail.com>
Co-developed-by: Taegyu Kim <tmk5904@psu.edu>
Signed-off-by: Taegyu Kim <tmk5904@psu.edu>
Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>

authored by

Yuho Choi and committed by
Helge Deller 9b8a9a3a 869b93ba

+2
+2
drivers/video/fbdev/savage/savagefb_driver.c
··· 2322 2322 failed: 2323 2323 #ifdef CONFIG_FB_SAVAGE_I2C 2324 2324 savagefb_delete_i2c_busses(info); 2325 + fb_destroy_modelist(&info->modelist); 2326 + fb_destroy_modedb(info->monspecs.modedb); 2325 2327 #endif 2326 2328 fb_alloc_cmap(&info->cmap, 0, 0); 2327 2329 savage_unmap_video(info);