tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

KVM: x86: don't fall through case statements without annotations

clang warns on this because it has an unannotated fall-through between
cases:

arch/x86/kvm/x86.c:4819:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]

and while we could annotate it as a fallthrough, the proper fix is to
just add the break for this case, instead of falling through to the
default case and the break there.

gcc also has that warning, but it looks like gcc only warns for the
cases where they fall through to "real code", rather than to just a
break. Odd.

Fixes: d30d9ee94cc0 ("KVM: x86: Only advertise KVM_CAP_READONLY_MEM when supported by VM")
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Tom Dohrmann <erbse.13@gmx.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Linus Torvalds 9d4c3040 6b8ff511

+1
+1
arch/x86/kvm/x86.c
··· 4816 4816 break; 4817 4817 case KVM_CAP_READONLY_MEM: 4818 4818 r = kvm ? kvm_arch_has_readonly_mem(kvm) : 1; 4819 + break; 4819 4820 default: 4820 4821 break; 4821 4822 }